~maria-captains/maria/5.1

Viewing all changes in revision 2502.1195.27.

  • Committer: Marko Mäkelä
  • Date: 2012-08-16 14:37:52 UTC
  • mto: (2502.1198.2 mysql-5.1)
  • mto: This revision was merged to the branch mainline in revision 3164.
  • Revision ID: marko.makela@oracle.com-20120816143752-0j7ipi92gdh5ylsr
Bug#12845774 OPTIMISTIC INSERT/UPDATE USES WRONG HEURISTICS FOR
COMPRESSED PAGE SIZE

This was submitted as MySQL Bug 61456 and a patch provided by
Facebook. This patch follows the same idea, but instead of adding a
parameter to btr_cur_pessimistic_insert(), we simply remove the
btr_cur_optimistic_insert() call there and add it to the only caller
that needs it.

btr_cur_pessimistic_insert(): Do not try btr_cur_optimistic_insert().

btr_insert_on_non_leaf_level_func(): Invoke btr_cur_optimistic_insert()
before invoking btr_cur_pessimistic_insert().

btr_cur_pessimistic_update(): Clarify in a comment why it is not
necessary to invoke btr_cur_optimistic_insert().

btr_root_raise_and_insert(): Assert that the root page is not empty.
This could happen if a pessimistic insert (involving a split or merge)
is performed without first attempting an optimistic (intra-page) insert.

rb:1219 approved by Sunny Bains

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: