-
Committer:
CI Train Bot
-
Author(s):
Albert Astals Cid
-
Date:
2016-01-11 17:37:22 UTC
-
mfrom:
(2099.2.6 xenial_lvwph_test_fix)
-
Revision ID:
ci-train-bot@canonical.com-20160111173722-k9tfmou2ocethxyr
Fix LVWPH test failing on Xenial (Qt 5.5)
This is the simplest of the ways of fixing the problem i found.
The issue is that flickable code doesn't play very well with the situation in which you have a contentHeight smaller than height and you reimplement minYExtent but not maxYExtent and minYExtent is returning a negative value.
The other solutions involve implementing maxYExtent figuring out why minYExtent ends up being negative on Qt 5.5 and not in Qt 5.4
Implementing maxYExtent seemed too much work and open a new can of worms
The different values of minYExtent in Qt 5.5 vs 5.4 are most probably ok since it's just different order invokations lead to different minyExtent+friends combinations that basically represent the same thing
So I ended up making sure the minYExtent is never negative (because it's 0) if the contentHeight is smaller than the height of the list
Approved by: Michael Terry