-
Committer:
Daniel Lee Harple
-
Date:
2013-10-28 22:02:36 UTC
-
Revision ID:
leeharple@gmail.com-20131028220236-1myze9dapfgx9ux4
Fix compiler warnings when using clang. Most of these warnings are only enabled when compiling with CODELEVEL > 0, which is why this is being committed to 0.4 rather than 0.2.8. It may make sense to back-port some of these fixes…
* configure.ac:
* Conditionally ignore some warnings.
* Fix boost::thread check. boost:thread::get_id is inlined, so check for boost::this_thread::yield.
* Check for libpng before freetype, since freetype 2.5 depends on png.
* For os-x-toolkit, use system-default stdlib. Fix FTGL_LIBS.
* Use isfinite() instead of finite() because finite() is deprecated on OS X 10.9.
* eLadderlog.h: fix nonsensical return type.
* nConfItemBase::WasChanged(bool): don't hide overloaded virtual functions. Rename to CheckChange(bool).
* eVoteItem::DoFillToMessage: don't hide overloaded virtual functions.
* nSocket.cpp: Use reinterpret_cast to silence warnings about increasing required alignment when casting from sockaddr to sockaddr_in.
* Pure virtual rISurfaceTexture::OnSelect() hides overloaded virtual functions. Rename to OnSelectCore().
* utf8.h, gCamera::CenterCycleDir, gWallRim::Height, gWallRim::SeeHeight: Use correct signature when overloading virtual functions.
* gCycleMovement.cpp: Be explicit about conversion from REAL to bool.
* Fix clang style warnings that are enabled by default: empty loop bodies; parentheses for bitwise operations.
* OS X stuff:
* Fix for SetFrontProcess since it is deprecated.
* Fix pedantic warnings.
* Don't use require_noerr, since it uses deprecated functions and multiple-character character constants (which produces warnings).