~akopytov/percona-server/utf8_general50_ci-5.1

Viewing all changes in revision 232.4.1.

  • Committer: Alexey Kopytov
  • Date: 2011-06-30 18:39:46 UTC
  • mto: This revision was merged to the branch mainline in revision 251.
  • Revision ID: akopytov@gmail.com-20110630183946-k9g4e858g36aemo9
Bug #794790: mtr internal check of INNODB_FILE_FORMAT_CHECK fails in
debug builds

The innodb_file_format_check system variable in 5.1 has dual purpose
(see MySQL bugs #49792 and #53654).

- at startup it takes an on/off value to enable/disable file format
checks by InnoDB;

- at runtime it is dynamically updated by InnoDB to the name of the
format actually read from the data file.

In particular, that updating occurs on recovery. So every test case
involving restarting the server and InnoDB recovery could fail due to
innodb_file_format_check value mismatch at the end of the test. To add
insult to injury, recovery (and thus, updating) is performed
asynchronously, so those failures were sporadic, occurring mostly on
slow machines or debug/valgrind builds.

Fixed by updating mtr_check.sql to ignore innodb_file_format_check. The
alternative approach would be to update all tests involving
restart/recovery, which I dislike.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: