- Committer: Alexey Kopytov
- Date: 2012-05-28 16:37:00 UTC
- Revision ID: akopytov@gmail.com-20120528163700-b1g6f9wu9ercssrp
Bug #713267: xtrabackup binary leaks file descriptors on --backup
The problem was that the xtrabackup_copy_datafile() called
fil_space_get_zip_size() with the only purpose to determine the
compressed page size for a tablespace. That function opens the tablespace
file to read its flags. But xtrabackup never closed that file, which was
the reason for the file descriptor leak.
Since we already have a file descriptor for the tablespace to be copied,
the bug was fixed duplicating a part of fil_node_open_file() in a
separate function that reads flags from a given tablespace file and then
converts them to the page size. The existing file descriptor is reused
this way, so no leak occurs.
The problem was that the xtrabackup_copy_datafile() called
fil_space_get_zip_size() with the only purpose to determine the
compressed page size for a tablespace. That function opens the tablespace
file to read its flags. But xtrabackup never closed that file, which was
the reason for the file descriptor leak.
Since we already have a file descriptor for the tablespace to be copied,
the bug was fixed duplicating a part of fil_node_open_file() in a
separate function that reads flags from a given tablespace file and then
converts them to the page size. The existing file descriptor is reused
this way, so no leak occurs.
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
contrib
|
241.2.1 | 13 years ago | Daniël van Eeden | Add contrib directory with an backup script exampl |
|
||
|
doc
|
213.3.1 | 13 years ago | Aleksandr Kuzminsky | Added XtraBackup manual page |
|
||
|
patches
|
228.1.2 | 13 years ago | Alexey Kopytov | Port XtraBackup to Percona Server 5.5.9-beta20.1 c |
|
||
|
test
|
134.1.1 | 13 years ago | Aleksandr Kuzminsky | Added the XtraBackup test framework |
|
||
|
utils
|
30.1.2 | 15 years ago | Vadim Tkachenko | directory restructure |
|
||
BUILD.txt |
280 | 12 years ago | Stewart Smith | backport BUILD.txt fixes | 2.7 KB |
|
|
|
COPYING |
174.1.1 | 13 years ago | Stewart Smith | add COPYING file with GPLv2 license. xtrabackup is | 18.6 KB |
|
|
innobackupex |
339 | 11 years ago | Alexey Kopytov | Bug #1002688: innobackupex incremental apply-log c | 96 KB |
|
|
innobackupex-1.5.1
|
216 | 13 years ago | Vadim Tkachenko | Bugfix #701767 Script innobackupex-1.5.1 renamed | . |
|
|
|
Makefile |
297 | 12 years ago | Stewart Smith | Merge 1.4 release tag | 7.8 KB |
|
|
|
VERSION |
327 | 12 years ago | Stewart Smith | bump version number after 1.6.5 release | 25 bytes |
|
|
|
xtrabackup.c |
340 | 11 years ago | Alexey Kopytov | Bug #713267: xtrabackup binary leaks file descript | 175 KB |
|
|