1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
|
/*
* Copyright © 2013-2014 Canonical Ltd.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 or 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* Authored by: Robert Carr <robert.carr@canonical.com>
*/
#include "mir/frontend/session_credentials.h"
#include "mir/frontend/session_authorizer.h"
#include <mir_toolkit/mir_client_library.h>
#include "mir/test/fake_shared.h"
#include "mir_test_framework/interprocess_client_server_test.h"
#include "mir/test/doubles/stub_session_authorizer.h"
#include <gtest/gtest.h>
#include <gmock/gmock.h>
#include <sys/mman.h>
#include <sys/types.h>
#include <semaphore.h>
#include <time.h>
#include <unistd.h>
namespace mf = mir::frontend;
namespace mt = mir::test;
namespace mtf = mir_test_framework;
namespace mtd = mir::test::doubles;
using namespace ::testing;
namespace
{
struct MockSessionAuthorizer : public mf::SessionAuthorizer
{
MOCK_METHOD1(connection_is_allowed, bool(mf::SessionCredentials const&));
MOCK_METHOD1(configure_display_is_allowed, bool(mf::SessionCredentials const&));
MOCK_METHOD1(set_base_display_configuration_is_allowed, bool(mf::SessionCredentials const&));
MOCK_METHOD1(screencast_is_allowed, bool(mf::SessionCredentials const&));
MOCK_METHOD1(prompt_session_is_allowed, bool(mf::SessionCredentials const&));
MOCK_METHOD1(configure_input_is_allowed, bool(mf::SessionCredentials const&));
MOCK_METHOD1(set_base_input_configuration_is_allowed, bool(mf::SessionCredentials const&));
};
struct ClientCredsTestFixture : mtf::InterprocessClientServerTest
{
ClientCredsTestFixture()
{
shared_region = static_cast<SharedRegion*>(
mmap(NULL, sizeof(SharedRegion), PROT_READ | PROT_WRITE,
MAP_ANONYMOUS | MAP_SHARED, 0, 0));
sem_init(&shared_region->client_creds_set, 1, 0);
}
struct SharedRegion
{
sem_t client_creds_set;
pid_t client_pid = -1;
uid_t client_uid = -1;
gid_t client_gid = -1;
bool matches_client_process_creds(mf::SessionCredentials const& creds)
{
// A perfect match is perfect. But sometimes it's not a perfect
// match and that's OK too. Because fakeroot (used in deb builds)
// returns 0 unconditionally, even for non-root users.
return client_pid == creds.pid() &&
(client_uid == 0 || client_uid == creds.uid()) &&
(client_gid == 0 || client_gid == creds.gid());
}
bool wait_for_client_creds()
{
static time_t const timeout_seconds = 60;
struct timespec abs_timeout = { time(NULL) + timeout_seconds, 0 };
return sem_timedwait(&client_creds_set, &abs_timeout) == 0;
}
void post_client_creds()
{
client_pid = getpid();
client_uid = geteuid();
client_gid = getegid();
sem_post(&client_creds_set);
}
};
SharedRegion* shared_region;
MockSessionAuthorizer mock_authorizer;
};
}
TEST_F(ClientCredsTestFixture, session_authorizer_receives_pid_of_connecting_clients)
{
auto const matches_creds = [&](mf::SessionCredentials const& creds)
{
return shared_region->matches_client_process_creds(creds);
};
init_server([&]
{
server.override_the_session_authorizer(
[&] { return mt::fake_shared(mock_authorizer); });
EXPECT_CALL(mock_authorizer,
connection_is_allowed(Truly(matches_creds)))
.Times(1)
.WillOnce(Return(true));
EXPECT_CALL(mock_authorizer,
configure_display_is_allowed(Truly(matches_creds)))
.Times(1)
.WillOnce(Return(false));
EXPECT_CALL(mock_authorizer,
screencast_is_allowed(Truly(matches_creds)))
.Times(1)
.WillOnce(Return(false));
EXPECT_CALL(mock_authorizer,
prompt_session_is_allowed(Truly(matches_creds)))
.Times(1)
.WillOnce(Return(false));
});
run_in_server([&]
{
EXPECT_TRUE(shared_region->wait_for_client_creds());
});
run_in_client([&]
{
shared_region->post_client_creds();
auto const connection = mir_connect_sync(mir_test_socket, __PRETTY_FUNCTION__);
ASSERT_TRUE(mir_connection_is_valid(connection));
mir_connection_release(connection);
});
}
// This test is also a regression test for https://bugs.launchpad.net/mir/+bug/1358191
TEST_F(ClientCredsTestFixture, authorizer_may_prevent_connection_of_clients)
{
init_server([&]
{
server.override_the_session_authorizer(
[&] { return mt::fake_shared(mock_authorizer); });
EXPECT_CALL(mock_authorizer,
connection_is_allowed(_))
.Times(1)
.WillOnce(Return(false));
});
run_in_server([&]{});
run_in_client([&]
{
auto const connection = mir_connect_sync(mir_test_socket, __PRETTY_FUNCTION__);
EXPECT_FALSE(mir_connection_is_valid(connection));
mir_connection_release(connection);
});
}
|