~asbalderson/jenkins-launchpad-plugin/private-repo

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
import unittest
from mock import patch
from mock import MagicMock
import tests.util as util
from jlp import get_config_option
from tarmac.exceptions import TarmacMergeError, BranchHasConflicts
from bzrlib.errors import LockFailed
from jlp.launchpadutils import LaunchpadVote
import jlp.commands.autoland as autoland


class TestGetFixesCommitMessage(unittest.TestCase):
    def test_with_bugs(self):
        mp = MagicMock()
        mp.source_branch.linked_bugs_collection = []
        for i in range(4):
            b = MagicMock()
            b.web_link = 'http://' + str(i)
            mp.source_branch.linked_bugs_collection.append(b)
        ret = autoland.get_fixes_commit_message(mp)
        expected = ' Fixes: http://0, http://1, http://2, http://3.'
        self.assertEqual(ret, expected)

    def test_no_bugs(self):
        mp = MagicMock()
        mp.source_branch.linked_bugs_collection = []
        ret = autoland.get_fixes_commit_message(mp)
        expected = ''
        self.assertEqual(ret, expected)


class TestLastMpVote(unittest.TestCase):
    def test_with_no_votes(self):
        mp = MagicMock()
        mp.votes = []
        ret = autoland.get_last_mp_vote(mp)
        self.assertEqual(ret, None)

    def test_with_no_votes_from_jenkins(self):
        mp = MagicMock()
        vote = MagicMock()
        vote.registrant.name = 'random-user'
        mp.votes = [vote]
        ret = autoland.get_last_mp_vote(mp)
        self.assertEqual(ret, None)

    def test_with_jenkins_vote(self):
        mp = MagicMock()
        expected_vote = 'Approved'
        vote = MagicMock()
        vote.registrant.name = 'random-user'
        vote2 = MagicMock()
        vote2.registrant.name = get_config_option('launchpad_login')
        vote2.comment.vote = expected_vote
        mp.votes = [vote, vote2]
        ret = autoland.get_last_mp_vote(mp)
        self.assertEqual(ret, expected_vote)

    def test_with_registered_voter_but_no_vote_yet(self):
        mp = MagicMock()
        vote = MagicMock()
        vote.registrant.name = get_config_option('launchpad_login')
        vote.comment = None
        mp.votes = [vote]
        ret = autoland.get_last_mp_vote(mp)
        self.assertEqual(ret, None)


class TestFormatCommitMessage(unittest.TestCase):
    def setUp(self):
        self.fixes = ' Fixes: http://0, http://1'
        self.approved_by = 'x, y, z'
        self.get_fixes_commit_message = lambda x: self.fixes
        self.get_approved_by_commit_message = lambda x: self.approved_by

        self.get_fixes_patch = patch(
            'jlp.commands.autoland.get_fixes_commit_message',
            new=self.get_fixes_commit_message)
        self.get_approved_by_patch = patch(
            'jlp.commands.autoland.get_approved_by_commit_message',
            new=self.get_approved_by_commit_message)
        self.get_fixes_patch.start()
        self.get_approved_by_patch.start()

    def tearDown(self):
        self.get_fixes_patch.stop()
        self.get_approved_by_patch.stop()

    def test_with_dot(self):
        mp = None
        commit_message = 'this is fixing a bug.'
        ret = autoland.format_commit_message(mp, commit_message)
        expected = commit_message + self.fixes + "\n\n" + \
            "Approved by " + self.approved_by + '.'
        self.assertEqual(ret, expected)

    def test_without_dot(self):
        mp = None
        commit_message = 'this is fixing a bug'
        ret = autoland.format_commit_message(mp, commit_message)
        expected = commit_message + '.' + self.fixes + "\n\n" + \
            "Approved by " + self.approved_by + '.'
        self.assertEqual(ret, expected)

    def test_with_empty_approved(self):
        mp = None
        self.approved_by = ''
        commit_message = 'this is fixing a bug.'
        ret = autoland.format_commit_message(mp, commit_message)
        expected = commit_message + self.fixes
        self.assertEqual(ret, expected)


class TestGetApprovedByCommitMessage(unittest.TestCase):
    def test_approved_by(self):
        mp = MagicMock()
        mp.votes = []
        for i in range(4):
            vote = MagicMock()
            vote.comment.vote = LaunchpadVote.APPROVE
            vote.reviewer.display_name = str(i)
            mp.votes.append(vote)
        ret = autoland.get_approved_by_commit_message(mp)
        expected = '0, 1, 2, 3'
        self.assertEqual(ret, expected)

    def test_approved_by_empty(self):
        mp = MagicMock()
        mp.votes = []
        ret = autoland.get_approved_by_commit_message(mp)
        expected = ''
        self.assertEqual(ret, expected)


class TestAutoland(unittest.TestCase):
    def setUp(self):
        get_launchpad = lambda launchpadlib_dir: MagicMock()
        self.get_launchpad_patch = patch('jlp.commands.autoland.get_launchpad',
                                         new=get_launchpad)
        self.get_launchpad_patch.start()

        self.mp = MagicMock()
        self.mp.source_branch.display_name = 'lp:~team/unity/lp-111222'
        self.mp.target_branch.display_name = 'lp:unity'
        self.vote_subject = 'Re: [Merge] lp:~team/unity/lp-111222 into ' +\
                            'lp:unity'
        self.get_mp_handle_from_url_patch = patch(
            'jlp.commands.autoland.launchpadutils.get_mp_handle_from_url',
            return_value=self.mp)
        self.get_mp_handle_from_url = self.get_mp_handle_from_url_patch.start()

        self.get_branch_from_mp_patch = patch(
            'jlp.commands.autoland.launchpadutils.get_branch_from_mp')
        self.get_branch_from_mp = self.get_branch_from_mp_patch.start()

        self.change_mp_status_patch = patch(
            'jlp.commands.autoland.launchpadutils.change_mp_status')
        self.change_mp_status = self.change_mp_status_patch.start()

    def tearDown(self):
        self.get_launchpad_patch.stop()
        self.get_branch_from_mp_patch.stop()
        self.change_mp_status_patch.stop()
        self.get_mp_handle_from_url_patch.stop()


class TestAutolandForMergeAndCommit(TestAutoland):
    def setUp(self):
        super(TestAutolandForMergeAndCommit, self).setUp()

        target = MagicMock()
        target.bzr_branch.revision_id_to_revno = MagicMock(return_value=100)
        target.bzr_branch.revno = MagicMock(return_value=50)
        branch = MagicMock()
        branch.create = MagicMock(return_value=target)
        self.branch_patch = patch('jlp.commands.autoland.Branch', new=branch)
        self.target = target
        self.Branch = self.branch_patch.start()

    def tearDown(self):
        super(TestAutolandForMergeAndCommit, self).tearDown()
        self.branch_patch.stop()


class TestAutolandMergeAndCommit(TestAutolandForMergeAndCommit):
    @patch('jlp.launchpadutils.close_bugs')
    def test_merge_and_commit_push_error(self, close_bugs_mock):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 0)
            self.assertTrue(self.target.merge.call_count == 1)
            self.assertTrue(self.target.commit.call_count == 1)
            self.assertTrue(close_bugs_mock.call_count == 1)


class TestAutolandVoting(TestAutolandForMergeAndCommit):
    def test_last_vote_was_needs_fixing(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        merge_and_commit = lambda x, y: 0
        get_last_mp_vote = lambda x: LaunchpadVote.NEEDS_FIXING
        with patch('sys.argv', sys_argv), \
            patch(
                'jlp.commands.autoland.get_last_mp_vote', get_last_mp_vote), \
                patch(
                    'jlp.commands.autoland.merge_and_commit',
                    merge_and_commit):
            autoland.autoland()
            self.mp.createComment.assert_called_once_with(
                review_type=get_config_option('launchpad_review_type'),
                vote=LaunchpadVote.APPROVE,
                subject=self.vote_subject)

    def test_last_vote_was_approved(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        merge_and_commit = lambda y, z: 0
        get_last_mp_vote = lambda x: LaunchpadVote.APPROVE
        with patch('sys.argv', sys_argv), \
            patch('jlp.commands.autoland.get_last_mp_vote',
                  get_last_mp_vote), \
                patch('jlp.commands.autoland.merge_and_commit',
                      merge_and_commit):
            autoland.autoland()
            self.assertEquals(self.mp.createComment.call_count, 0)


class TestAutolandMergeAndCommitWithDescription(TestAutolandForMergeAndCommit):
    def setUp(self):
        super(TestAutolandMergeAndCommitWithDescription, self).setUp()
        self.mp.commit_message = ''
        self.mp.description = 'my description'

    @patch('jlp.launchpadutils.close_bugs')
    def test_merge_and_commit_with_description(self, close_bugs_mock):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url', '-u']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 0)
            self.assertTrue(self.target.merge.call_count == 1)
            self.assertTrue(self.target.commit.call_count == 1)
            self.assertTrue(close_bugs_mock.call_count == 1)


class TestAutolandWithMultipleDputs(TestAutolandForMergeAndCommit):
    def test_multiple_dputs(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url', '-p', 'ppa:myppa,ppa:myppa2',
                    '-d', 'quantal,precise']
        dputRunner = MagicMock()
        with patch('sys.argv', sys_argv), \
                patch('jlp.commands.autoland.DputRunner', new=dputRunner):
            self.assertTrue(autoland.autoland() == 0)
            ppas_expected = ['ppa:myppa', 'ppa:myppa2']
            distributions_expected = ['quantal', 'precise']
            self.assertEquals(ppas_expected, dputRunner.call_args[1]['ppas'])
            self.assertEquals(distributions_expected,
                              dputRunner.call_args[1]['distributions'])


class TestAutolandWithReleaseOnly(TestAutolandForMergeAndCommit):
    def test_release_only(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url', '-p', 'ppa:myppa',
                    '-d', 'quantal', '--release-only']
        dputRunner = MagicMock()
        with patch('sys.argv', sys_argv), \
                patch('jlp.commands.autoland.DputRunner', new=dputRunner):
            autoland.autoland()
            self.assertTrue(dputRunner.call_args[1]['release_only'])


class TestAutolandWithVersionFormatString(TestAutolandForMergeAndCommit):
    def test_unqouted_string(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url', '-p', 'ppa:myppa',
                    '-d', 'quantal', '-f', '{PACKAGE_VERSION}0']
        dputRunner = MagicMock()
        with patch('sys.argv', sys_argv), \
                patch('jlp.commands.autoland.DputRunner', new=dputRunner):
            self.assertTrue(autoland.autoland() == 0)
            version_format_expected = '{PACKAGE_VERSION}0'
            self.assertEquals(version_format_expected,
                              dputRunner.call_args[1]['versionFormat'])

    def test_quoted_string(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url', '-p', 'ppa:myppa',
                    '-d', 'quantal', '-f', '"{PACKAGE_VERSION}"']
        dputRunner = MagicMock()
        with patch('sys.argv', sys_argv), \
                patch('jlp.commands.autoland.DputRunner', new=dputRunner):
            self.assertTrue(autoland.autoland() == 0)
            version_format_expected = '{PACKAGE_VERSION}'
            self.assertEquals(version_format_expected,
                              dputRunner.call_args[1]['versionFormat'])


class TestAutolandMergeCommitAndDput(TestAutolandForMergeAndCommit):
    def setUp(self):
        super(TestAutolandMergeCommitAndDput, self).setUp()
        self.dputRunner = MagicMock()
        self.dputRunner_patch = patch(
            'jlp.commands.autoland.DputRunner',
            new=MagicMock(return_value=self.dputRunner))
        self.dputRunner_patch.start()

    def tearDown(self):
        super(TestAutolandMergeCommitAndDput, self).tearDown()
        self.dputRunner_patch.stop()

    @patch('jlp.launchpadutils.close_bugs')
    def test_merge_and_commit_push_error(self, close_bugs_mock):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url', '-p', 'ppa:myppa',
                    '-a', 'packaging_branch', '-b',
                    'http://10.0.0.1:8080/job/unity-daily/17/', '-d',
                    'precise']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 0)
            self.assertTrue(self.target.merge.call_count == 1)
            self.assertTrue(self.target.commit.call_count == 1)
            self.assertTrue(close_bugs_mock.call_count == 1)
            self.assertTrue(self.dputRunner.dput.call_count == 1)


class TestAutolandMergeAndCommitMergeConflict(TestAutoland):
    def setUp(self):
        super(TestAutolandMergeAndCommitMergeConflict, self).setUp()

        source = MagicMock()
        source.bzr_branch.revision_id_to_revno = MagicMock(return_value=100)
        source.bzr_branch.revno = MagicMock(return_value=50)
        source.merge.side_effect = BranchHasConflicts('branchHasConflicts')
        branch = MagicMock()
        branch.create = MagicMock(return_value=source)
        self.branch_patch = patch('jlp.commands.autoland.Branch', new=branch)
        self.Branch = self.branch_patch.start()

    def tearDown(self):
        super(TestAutolandMergeAndCommitMergeConflict, self).tearDown()
        self.branch_patch.stop()

    def test_merge_and_commit_merge_conflict(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 1)


class TestAutolandMergeAndCommitPushFailed(TestAutoland):
    def setUp(self):
        super(TestAutolandMergeAndCommitPushFailed, self).setUp()
        source = MagicMock()
        source.bzr_branch.revision_id_to_revno = MagicMock(return_value=100)
        source.bzr_branch.revno = MagicMock(return_value=50)
        source.merge.side_effect = TarmacMergeError('tarmacMergeError')
        branch = MagicMock()
        branch.create = MagicMock(return_value=source)
        self.branch_patch = patch('jlp.commands.autoland.Branch', new=branch)
        self.Branch = self.branch_patch.start()

    def tearDown(self):
        super(TestAutolandMergeAndCommitPushFailed, self).tearDown()
        self.branch_patch.stop()

    def test_merge_and_commit_push_error(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 1)


class TestAutolandMergeAndCommitLockFailed(TestAutoland):
    def setUp(self):
        super(TestAutolandMergeAndCommitLockFailed, self).setUp()
        source = MagicMock()
        source.bzr_branch.revision_id_to_revno = MagicMock(return_value=100)
        source.bzr_branch.revno = MagicMock(return_value=50)
        source.merge.side_effect = LockFailed('LockFailed', '')
        branch = MagicMock()
        branch.create = MagicMock(return_value=source)
        self.branch_patch = patch('jlp.commands.autoland.Branch', new=branch)
        self.Branch = self.branch_patch.start()

    def tearDown(self):
        super(TestAutolandMergeAndCommitLockFailed, self).tearDown()
        self.branch_patch.stop()

    def test_merge_and_commit_lock_failed(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 1)


class TestAutolandMergeAndCommitUnapprovedChange(TestAutoland):
    def setUp(self):
        super(TestAutolandMergeAndCommitUnapprovedChange, self).setUp()

        source = MagicMock()
        source.bzr_branch.revision_id_to_revno = MagicMock(return_value=100)
        source.bzr_branch.revno = MagicMock(return_value=500)
        branch = MagicMock()
        branch.create = MagicMock(return_value=source)
        self.branch_patch = patch('jlp.commands.autoland.Branch', new=branch)
        self.Branch = self.branch_patch.start()

    def tearDown(self):
        super(TestAutolandMergeAndCommitUnapprovedChange, self).tearDown()
        self.branch_patch.stop()

    def test_merge_and_commit_unapproved_change(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 1)
            self.assertTrue(
                self.change_mp_status.call_count == 1)


class TestAutolandInvalidRevid(TestAutoland):
    def setUp(self):
        super(TestAutolandInvalidRevid, self).setUp()
        self.mp.reviewed_revid = None

    def tearDown(self):
        super(TestAutolandInvalidRevid, self).tearDown()

    def test_merge_and_commit_unapproved_change(self):
        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 1)
            self.assertTrue(
                self.change_mp_status.call_count == 1)


class TestAutolandEmptyCommitMessage(TestAutoland):

    def setUp(self):
        super(TestAutolandEmptyCommitMessage, self).setUp()
        self.get_commit_message_patch = patch(
            'jlp.launchpadutils.get_commit_message',
            new=lambda x, y: None)
        self.get_commit_message_patch.start()

    def tearDown(self):
        super(TestAutolandEmptyCommitMessage, self).tearDown()
        self.get_commit_message_patch.stop()

    def test_empty_commit_message(self):
        """Test the 'empty commit message' error."""

        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 1)
            self.assertTrue(
                self.change_mp_status.call_count == 1)

    def test_empty_commit_message_and_description(self):
        """Test the 'empty commit message' error."""

        sys_argv = ['autoland.py', '-r', 'PASSED',
                    '-v', '123', '-m', 'url', '-u']
        with patch('sys.argv', sys_argv):
            self.assertTrue(autoland.autoland() == 1)
            self.assertTrue(
                self.change_mp_status.call_count == 1)


class TestAutoland(unittest.TestCase):

    def setUp(self):
        self.get_launchpad_patch = patch('jlp.commands.autoland.get_launchpad')
        self.get_launchpad_patch.start()

    def tearDown(self):
        self.get_launchpad_patch.stop()

    def test_gibberish(self):
        """Gibberish on the command line produces usage message."""

        sys_argv = ['--oheck']
        with patch('sys.argv', sys_argv), \
                util.captured_stderr() as stderr:
            try:
                autoland.autoland()
            except SystemExit:
                pass
            self.assertTrue("usage" in stderr.getvalue())

    @patch('jlp.commands.autoland.launchpadutils.get_branch_from_mp')
    @patch('jlp.commands.autoland.launchpadutils.change_mp_status')
    def test_test_result_failed(self, change_mp_status_mock, get_branch_mock):
        """Fail autolanding because of failed testing"""

        sys_argv = ['autoland.py', '-r', 'FAILED',
                    '-v', '123', '-m', 'url']
        with patch('sys.argv', sys_argv):
                autoland.autoland()
                self.assertTrue(
                    change_mp_status_mock.call_count == 1)