~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname

Viewing all changes in revision 2131.

  • Committer: Andrew Wilkins
  • Date: 2013-12-11 04:19:53 UTC
  • Revision ID: andrew.wilkins@canonical.com-20131211041953-qtd04if59bg6cdj6
provider/common: refresh DNS name during waitSSH

Synchronous bootstrap starts by creating a new
instance, and then attempting to connect to the
instance's SSH port. The method we were using
assumed that the instance would be started with
a public address to begin with, which is not
always the case. We now refresh addresses during
bootstrap.

An alternative approach would be to initially
wait until an actually public address is available,
rather than a "most public" address as returned by
instance.SelectPublicAddress. I considered this to
be a bit more fragile: providers might not know
whether an address is "public" (i.e. all addresses
might be NetworkUnknown), and that approach also
wouldn't cater for changes to public addresses.

Fixes #1258240

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: