~bac/charmworld/tag-constraints : changes

~bac/charmworld/tag-constraints » Changes from revision 483

From Revision 483 to 464

Rev	Summary	Authors	Date
483	Add an index for db.charms. Add an index for db.charms. Without the proper index, sorting mongo results fail. * Add setup_mongo_indices and make it idempotent. * Lots of tests. * Change migration 'initialize' to call setup_mongo_indices. * Add a migration for existing dbs. * Drive by ugliness The migration scripts, even long-lived ones like test_migrations.py, were quite dirty lint-wise. Turns out the Makefile was excluding them explicitly. Changed the lint target and then had to fix the old scripts. https://codereview.appspot.com/61720043/ R=jcsackett. Fixes: https://bugs.launchpad.net/bugs/1278222. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
482	Add support for debug mode in getting charm icons. Add support for debug mode in getting charm icons. Normally a non-promulgated charm will get the generic icon, even if it has its own icon. Adding a '?debug' querystring will cause it to return the actual icon. Landing this change for Rick Harding. * Changed debug default value to False from None. * Added a test for a non-promulgated charm that does have an icon but no debug querystring. https://codereview.appspot.com/49700045/ R=bac. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
481	Updates the criteria for trigger_tests to prevent excessive ... Updates the criteria for trigger_tests to prevent excessive test calls. Fixes: https://bugs.launchpad.net/bugs/1272023. Approved by Juju Gui Bot, j.c.sackett, Brad Crittenden.	j.c.sackett	11 years ago
480	Fixes an enqueue error for ingest that occurs because of a n... Fixes an enqueue error for ingest that occurs because of a non-indexed sort. Approved by Juju Gui Bot, j.c.sackett, Brad Crittenden.	j.c.sackett	11 years ago
479	Add a very useful hint about relation ordering. Add a very useful hint about relation ordering. Approved by Juju Gui Bot.	Benji York	11 years ago
478	Improves the trigger_tests function with logging, and correc... Improves the trigger_tests function with logging, and corrects an error in url construction. Approved by Juju Gui Bot, Curtis Hovey.	j.c.sackett	11 years ago
477	Clear queues at ingest startup. Clear queues at ingest startup. Bundles seem to get stuck when the job entries are locked and the ingest process dies, such as happens when charm attributes are set or the charm gets updated. To avoid having the queues littered with items that never go away, which is disconcerting to the casual viewer of /heartbeat, this branch introduces a new --clear option to the queueing process which is used by the worker on the first invocation This branch also addresses a few other issues by being more defensive in the face of charms and bundles that are non-standard in a number of ways. * Handle the lack of 'bundles.yaml' gracefully. * Handle SVG files with float placement values. * Handle charms with no files. The only instance I've seen of this occurring is with a charm that is private in Launchpad, so I cannot assess how it happens. https://codereview.appspot.com/51010046/ R=rharding. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
476	Properly proof bundles with inheritance. Properly proof bundles with inheritance. - Use the existing get_flattened_deployment to realize the inheritance. - Update to new version of charm-tools. - Specify version for charmworldlib rather than grabbing the latest from pypi. - Add work-around to forking charm-tools to allow proofing on localhost during ingest. QA: In one terminal: % make run In another: % bin/ingest-queued --prefix=~bac Ensure that ~bac/charms/bundle/complicated/bundle ingests A-OK. https://codereview.appspot.com/51650043/ R=rharding. Fixes: https://bugs.launchpad.net/bugs/1263112. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
475	Automatically trigger builds for new charms and new revision... Automatically trigger builds for new charms and new revisions of existing charms. Approved by Juju Gui Bot, Curtis Hovey.	j.c.sackett	11 years ago
474	Add two more questions to QA assessment. Add two more questions to QA assessment. https://codereview.appspot.com/49030044/ R=bac. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
473	Fix a bug that killed the worker. Fix a bug that killed the worker. Fixed 'wait_seconds' and added missing tests. Added stanzas for logging that are required until the production overrides in the charm are brought in. QA: run 'bin/ingest-queued --limit=10 --debug --run-forever' and see that it waits before proceeding. https://codereview.appspot.com/48540043/ R=rharding. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
472	Add docs for setting up ES and Nagios Add docs for setting up ES and Nagios Also fixed a branch URL in the docs that was no longer valid. Approved by Juju Gui Bot.	Benji York	11 years ago
471	Remove HTML from QA question titles. Remove HTML from QA question titles. The HTML displays properly in Charmworld. However when those titles are displayed in the Juju GUI they are rendered as plain text. Rather than changing the GUI it is easier to just move any HTML to the description portion of the question, which is not displayed by the GUI. The original changes to the QA questions have not yet been deployed on production so no migration is necessary. Migrations 022 and 023 will need to be run by hand on staging, however. https://codereview.appspot.com/47490043/ R=benji. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
470	Always update branches. Always update branches. This fixes a bug in which branches could have all the revisions available but be "at" an earlier revision than head. Approved by Juju Gui Bot, Benji York.	Benji York	11 years ago
469	Run charm/bundle queue and ingest from one script Run charm/bundle queue and ingest from one script Originally, queueing was run from a cronjob every fifteen minutes. Stuff was added without regard to it being queued up already. Ingest was run continuously but slept fifteen minutes when it completed before looking at the queue again. This change makes the supervisord-run worker do the queue job, then ingest charms and bundles. At the end, it sleeps for fifteen minutes minus the amount spent doing the work. The charmworld charm needs to be fixed to not create the cronjob for queueing. It hasn't been done yet but the bin/queued script that is called by the cronjob needs to be disabled before this change lands or the queueing will be run by two different approaches. https://codereview.appspot.com/45440043/ R=benji. Fixes: https://bugs.launchpad.net/bugs/1130732. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
468	New QA assessment questions. New QA assessment questions. A migration is necessary to remove the old questions and answers and then to reinstate the new ones. I've separated these two tasks into two different migrations for easier testing. Note the second one is forced to reach into Version and call the newly refactored setup_qa_data because initialize is only called if the database has not previously been versioned. https://codereview.appspot.com/44070045/ R=rick, benji. Fixes: https://bugs.launchpad.net/bugs/1257878. Approved by Juju Gui Bot, Benji York.	Brad Crittenden	11 years ago
467	Add download stats to bundle API call. Add download stats to bundle API call. https://codereview.appspot.com/29850043/ R=benji. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
466	Remove buggy jspark and create better sparklines. Remove buggy jspark and create better sparklines. Approved by Juju Gui Bot, Aaron Bentley.	j.c.sackett	11 years ago
465	Add a script to remove a charm Add a script to remove a charm https://codereview.appspot.com/29210043/ R=bac. Approved by Juju Gui Bot, Benji York.	Benji York	11 years ago
464	Handle some failure modes with better logging. Handle some failure modes with better logging. Approved by Juju Gui Bot, Aaron Bentley.	j.c.sackett	11 years ago

Older »