509
|
|
|
Reed O'Brien |
10 years ago
|
|
|
508
|
|
|
Brad Crittenden |
10 years ago
|
|
|
507
|
|
|
Brad Crittenden |
10 years ago
|
|
|
506
|
|
|
Brad Crittenden |
10 years ago
|
|
|
505
|
|
|
Brad Crittenden |
10 years ago
|
|
|
504
|
|
|
Brad Crittenden |
10 years ago
|
|
|
503
|
|
|
Brad Crittenden |
10 years ago
|
|
|
502
|
|
|
Brad Crittenden |
10 years ago
|
|
|
501
|
|
Do not index charm annotations in bundles.
Charms in bundles have "annotations" which include information relating to the widget layout when placed in the GUI ('gui-x' and 'gui-y'). This information is ancilliary to the actual bundle and should not be searchable.
The presence of such data has also caused operational problems. In production, some bundles are not being indexed due to parsing errors of the x and y coordinates.
An example failure is shown here: 2014-04-11 19:12:30,096 DEBUG [pyelasticsearch][MainThread] got response {u'items': [{u'index': {u'_type': u'bundle', u'_id': u'~charmers/muletrain/wiki', u'error': u'MapperParsingException[failed to parse [data.data.services.mediawiki.annotations.gui-y]]; nested: NumberFormatException[For input string: "-117.5"]; ', u'_index': u'charms-78512'}}], u'took': 4}
Unfortunately, this ingestion failure cannot be reproduced on staging or locally. Further, it appears pyelasticsearch is not returning an error in this situation but is instead silently failing to index the bundle.
To QA the branch, in one window run 'make run'. In another, ingest some bundles:
% bin/ingest-queued --prefix="~charmers/charms/bundles"
Afterwards, go to 'localhost:2464' in your browser. Search for 'bundles' and see the ones that got ingested. Next search for 'gui-x' and see no results.
https://codereview.appspot.com/87710043/
R=jcsackett.
Approved by Juju Gui Bot.
|
Brad Crittenden |
10 years ago
|
|
|
500
|
|
|
Brad Crittenden |
10 years ago
|
|
|
499
|
|
|
Brad Crittenden |
10 years ago
|
|
|
498
|
|
|
Brad Crittenden |
10 years ago
|
|
|
497
|
|
|
Brad Crittenden |
10 years ago
|
|
|
496
|
|
|
Brad Crittenden |
10 years ago
|
|
|
495
|
|
|
Brad Crittenden |
10 years ago
|
|
|
494
|
|
|
Rick Harding |
10 years ago
|
|
|
493
|
|
|
Brad Crittenden |
10 years ago
|
|
|
492
|
|
|
Benji York |
10 years ago
|
|
|
491
|
|
|
Brad Crittenden |
10 years ago
|
|
|
490
|
|
|
Matthew Scott |
10 years ago
|
|
|