~bac/charmworld/tag-constraints

  • Committer: Tarmac
  • Author(s): Brad Crittenden
  • Date: 2014-03-20 20:22:02 UTC
  • mfrom: (491.2.18 remove-bundles)
  • Revision ID: tarmac-20140320202202-syqt88y73u4d5rik
Add to GUI the ability to delete charms & bundles.

On the charm detail page, a 'Delete' link is added if the user has edit
permission.

On the bundle detail page, a new 'Actions' section is added that has 'Feature'
and 'Delete' links.

We talked about removing the charmworld/scripts/remove_charm.py file but that
isn't done in this branch.

QA: ingest some charms and bundles.  While not logged in, visit the charm and
bundle pages and notice you don't see the 'Delete' links.

Log in.

Now see the links.  Click 'Delete' then cancel or submit without checking the
box.  Note the charm isn't deleted.  Now delete it for real.  Note that it is
gone.  

Repeat for bundles.

Try featuring a bundle.

Late breaking thought:  deleting a charm that a bundle depends upon may cause
it to be undeployable.  Refuse to delete a charm if a bundle depends on it or
just leave it be?  Note this is no worse than the remove_charm.py script,
though it is easier to do.

https://codereview.appspot.com/78220043/

R=benji, makyo, rharding.

Approved by Juju Gui Bot.
Filename Latest Rev Last Changed Committer Comment Size
..
charmworld 1 13 years ago kapil.foss at gmail charmworld pyramid starter Diff
docs 33 13 years ago kapil.foss at gmail add install doc Diff
scripts 21 13 years ago Kapil Thangavelu add ctl scripts Diff
.bzrignore 458.1.3 11 years ago j.c.sackett Bzr should ignore our conventional lp credentials 430 bytes Diff Download File
.lbox 419.1.2 11 years ago Brad Crittenden lbox defaults to -cr and sets project to charmworl 31 bytes Diff Download File
File .lbox.check 491.1.2 10 years ago Brad Crittenden Move lint before test in lbox.check 66 bytes Diff Download File
CHANGES.txt 67.1.10 11 years ago Kapil Thangavelu put back accidentally yanked changes 28 bytes Diff Download File
default.ini 474.1.6 10 years ago j.c.sackett Changes to address commentar in review. 2.9 KB Diff Download File
distribute_setup.py 71.1.2 12 years ago Rick Harding Add missing files 15.3 KB Diff Download File
LICENSE.txt 61 12 years ago kapil.foss at gmail add license 33.7 KB Diff Download File
Makefile 482.1.1 10 years ago Brad Crittenden Turn on lint for migrations and fix 5.1 KB Diff Download File
MANIFEST.in 1 13 years ago kapil.foss at gmail charmworld pyramid starter 133 bytes Diff Download File
README.txt 7 13 years ago kapil.foss at gmail work in progress on multi namespace support 252 bytes Diff Download File
requirements.txt 487.2.1 10 years ago Brad Crittenden Check charm constraints when doing proof. Lots of 1.3 KB Diff Download File
setup.cfg 304.4.26 11 years ago Aaron Bentley Move logging filters to nose config. 569 bytes Diff Download File
setup.py 461.3.2 11 years ago Benji York checkpoint 1.4 KB Diff Download File
test-setup.ini 474.1.6 10 years ago j.c.sackett Changes to address commentar in review. 668 bytes Diff Download File