-
Committer:
Rick Harding
-
Author(s):
Richard Harding
-
Date:
2013-04-29 21:18:30 UTC
-
mfrom:
(620.5.35 filters)
-
Revision ID:
rick.harding@canonical.com-20130429211830-5ypm38kofirda2pn
Adds filter controls to the search in the browser
- The branch updates the models/browser.js Filter model that is basically the
search state in the application.
- The subapp keeps an instance of that around and updates it along with the
rest of the subapplication state.
- The subapp passes the raw data down into views that can use it to populate
the search related widgets (search and filters).
- When those widgets are changed they trigger a custom event back up to their
controlling View.
- That View then generates a change event to the subapp directing it to update
it's current _filter (the Filter model) with that change and navigate to the
new url.
- All searches are url-able and thus force a navigate and re-process through
the render chain.
- Because of this, the Views do not need to update their version of the
filters, they'll get new ones from the subapp on the next routing.
Known QA issues:
- There's not a good "no results found" display
- There's not a list of selected filters per UX design when the filter list is
collapsed in sidebar view
- Theme'ing needs to be done on the filter list to remove the leading *, make
things more header-like, add proper arrows vs temp ^/v
- It's felt these are correctable through the week while the functionality is
able to be added before 'feature freeze' on Monday.
R=j.c.sackett, benji
CC=
https://codereview.appspot.com/9003043