~barnowl/barnowl/master

Viewing all changes in revision 2319.

  • Committer: Anders Kaseorg
  • Date: 2017-10-07 07:11:38 UTC
  • Revision ID: git-v1:09530e6d0cb0cc0fffc24ff054dc0c301097f3e5
owl_perlconfig_hashref2message: Don’t pass uninitialized tm_isdst to mktime

strptime doesn’t initialize tm_isdst, so mktime was offsetting the
time by ±1 hour depending on uninitialized memory.  Initializing
tm_isdst to a negative value causes it to guess.  It will still guess
incorrectly during one hour of every year, but at least now the
behavior is defined.

(Discovered by valgrind.)

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: