← Back to branch summary

~barry/mailman/events-and-web

« back to all changes in this revision

Viewing changes to src/mailman/rest/tests/test_domains.py

  • Committer: Barry Warsaw
  • Date: 2012-04-22 21:33:33 UTC
  • mfrom: (7150.1.11 transactions)
  • Revision ID: barry@list.org-20120422213333-3skjqsjktooesgsl
Several non-functional improvements to the code base.

Reduce the explicit use of the config.db global by introducing two new
helpers:
 - A new transaction() context manager which will commit the transaction on
   successful exit, otherwise it will abort the transaction
 - A new dbconnection decorator which calls the decorated method with the
   Storm store object as the first argument (after self).  This can be used
   instead of config.db.store.

By reducing the explicit use of this global, we have a better chance of
refactoring it away in the future.  Still TODO: runner.py and lmtp.py.

Be explicit about the `store` attribute on the IDatabase interface.

More consistent use of __future__ imports.

Remove an obsolete command line script.

Show diffs side-by-side

added added

removed removed

Lines of Context:
src/mailman/rest/tests/test_domains.py
17
17
 
18
18
"""REST domain tests."""
19
19
 
20
 
from __future__ import absolute_import, unicode_literals
 
20
from __future__ import absolute_import, print_function, unicode_literals
21
21
 
22
22
__metaclass__ = type
23
23
__all__ = [
 
24
    'TestDomains',
24
25
    ]
25
26
 
26
27
 
30
31
from zope.component import getUtility
31
32
 
32
33
from mailman.app.lifecycle import create_list
33
 
from mailman.config import config
 
34
from mailman.database.transaction import transaction
34
35
from mailman.interfaces.listmanager import IListManager
35
36
from mailman.testing.helpers import call_api
36
37
from mailman.testing.layers import RESTLayer
41
42
    layer = RESTLayer
42
43
 
43
44
    def setUp(self):
44
 
        self._mlist = create_list('test@example.com')
45
 
        config.db.commit()
 
45
        with transaction():
 
46
            self._mlist = create_list('test@example.com')
46
47
 
47
48
    def test_bogus_endpoint_extension(self):
48
49
        # /domains/<domain>/lists/<anything> is not a valid endpoint.
67
68
 
68
69
    def test_lists_are_deleted_when_domain_is_deleted(self):
69
70
        # /domains/<domain> DELETE removes all associated mailing lists.
70
 
        create_list('ant@example.com')
71
 
        config.db.commit()
 
71
        with transaction():
 
72
            create_list('ant@example.com')
72
73
        content, response = call_api(
73
74
            'http://localhost:9001/3.0/domains/example.com', method='DELETE')
74
75
        self.assertEqual(response.status, 204)