963
|
|
|
Jeff Pihach |
10 years ago
|
|
|
962
|
|
|
Matthew Scott |
10 years ago
|
|
|
961
|
|
|
Huw Wilkins |
10 years ago
|
|
|
960
|
|
|
Jeff Pihach |
10 years ago
|
|
|
959
|
|
|
j.c.sackett |
10 years ago
|
|
|
958
|
|
|
Richard Harding |
10 years ago
|
|
|
957
|
|
|
Matthew Scott |
10 years ago
|
|
|
956
|
|
|
Jeff Pihach |
10 years ago
|
|
|
955
|
|
|
Richard Harding |
10 years ago
|
|
|
954
|
|
|
j.c.sackett |
10 years ago
|
|
|
953
|
|
|
Richard Harding |
10 years ago
|
|
|
952
|
|
|
Richard Harding |
10 years ago
|
|
|
951
|
|
|
j.c.sackett |
10 years ago
|
|
|
950
|
|
|
Benjamin Saller |
10 years ago
|
|
|
949
|
|
|
Matthew Scott |
10 years ago
|
|
|
948
|
|
|
Richard Harding |
10 years ago
|
|
|
947
|
|
|
j.c.sackett |
10 years ago
|
|
|
946
|
|
|
Jeff Pihach |
10 years ago
|
|
|
945
|
|
|
Richard Harding |
10 years ago
|
|
|
944
|
|
Removes autocomplete feature flag, updates design
- Updates the CSS to more closely match the UX visual: https://drive.google.com/a/canonical.com/?pli=1#folders/0B7XG_QBXNwY1ZmdTTDdTZEdFOGM
Addresses notes from initial UX feedback, see the following: - Spacing, font size, and horizontal lines need to be adjusted. - Particularly notice the darker line between categories and charms (search for "ap" to see what I mean). - Please remove the "recommended" star. All autocomplete charm results are recommended, so it is unnecessary.
This required adjusting how the results were rendered and we add additional css classes on the tokens displayed to help the css find the last category result (for the longer bolder line), and for telling categories from charms.
Tests were refactored to place heavier functional tests in their own suite so that they could have standardized setup/teardown that was more costly than most of the basic tests. Also added tests for the css generation mentioned above.
Please QA: instructions
- Load the sidebar, search for a result. The best current example is 'a' as that pulls in two categories and several results. Check for the design spacing and borders. Note that the last result will not have a border on the bottom. - Try the same in fullscreen - Search, click, search some more. Anything that doesn't behave or look correct please bring up. This removes the feature flag and provides autocomplete to all users ootb.
R=j.c.sackett, benjamin.saller CC= https://codereview.appspot.com/12545044
|
Richard Harding |
10 years ago
|
|
|