-
Committer:
Rick Harding
-
Author(s):
Richard Harding
-
Date:
2013-08-15 16:16:21 UTC
-
mfrom:
(954.1.2 ie-whitespace-1207045)
-
Revision ID:
rick.harding@canonical.com-20130815161621-fzpd5sxezoi11eto
Fixes #1207045 extra whitespace in charm details
- When going from fullscreen editorial or search results to a charm details
the height was always matched to the editorial/results height. This causes
extra whitespace in the charm details layout.
- This was due to the indidicator spinner used for activity. It's using a
yui-hidden class when not showing to hide, but that causes it to still force
height.
- In the end, we can destroy the outdated content when we navigate to the
details. In fact, we should clean it up regardless. This adds code and a test
to verify that the .fullscreen() browser subapp function will clean older
editorial/search results views.
QA:
Go to /fullscreen, click on a charm. The height should be tighter to the end
of the charm details content. Compare against
comingsoon.jujucharms.com/fullscreen (and the same charm)
R=matthew.scott, j.c.sackett
CC=
https://codereview.appspot.com/12997043