- Committer: Francesco Banconi
- Date: 2013-01-22 14:37:57 UTC
- mfrom: (334.3.5 bug-1102638-ambigous-relation)
- Revision ID: francesco.banconi@canonical.com-20130122143757-g1wgs00q8dbndwdd
Fix ambiguous relation selector
When there are ambiguous relations clicking
to select one or the other does nothing.
This bug affected only our production server,
devel and debug worked well. This is weird,
and I think we are encountering the strange
behavior described in
http://yuilibrary.com/projects/yui3/ticket/2532993
or similar: in some situation (e.g. our production
server, where js files are minified/compressed)
using the "on" method on NodeList does not work.
I am confused about the real reason for this bug.
However, the documentation says that we should
avoid using NodeList.on, in favor of using event
delegation, that is exactly what I did in this
branch. Tests are not included: we have a specific
card for adding tests for the relation module.
R=benji, gary.poster
CC=
https://codereview.appspot.com/7177050
When there are ambiguous relations clicking
to select one or the other does nothing.
This bug affected only our production server,
devel and debug worked well. This is weird,
and I think we are encountering the strange
behavior described in
http://yuilibrary.com/projects/yui3/ticket/2532993
or similar: in some situation (e.g. our production
server, where js files are minified/compressed)
using the "on" method on NodeList does not work.
I am confused about the real reason for this bug.
However, the documentation says that we should
avoid using NodeList.on, in favor of using event
delegation, that is exactly what I did in this
branch. Tests are not included: we have a specific
card for adding tests for the relation module.
R=benji, gary.poster
CC=
https://codereview.appspot.com/7177050
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
_build
|
1 | 12 years ago | kapil.foss at gmail | initial layout |
|
||
|
_static
|
1 | 12 years ago | kapil.foss at gmail | initial layout |
|
||
|
_templates
|
1 | 12 years ago | kapil.foss at gmail | initial layout |
|
||
architecture.rst |
317.1.2 | 11 years ago | Nicola Larosa | Merge from trunk, three conflicts resolved. | 1.6 KB |
|
|
|
conf.py |
322.2.5 | 11 years ago | Nicola Larosa | Change the composite version number to the format | 9.5 KB |
|
|
|
d3-component-framework.rst |
314.2.4 | 11 years ago | Nicola Larosa | Fixes as per reviews. | 11.6 KB |
|
|
hacking.rst
|
274.1.1 | 11 years ago | Nicola Larosa | Move the hacking doc from README to HACKING, updat | . |
|
|
|
index.rst |
322.2.2 | 11 years ago | Nicola Larosa | Add the version extraction code, more doc tweaks. | 367 bytes |
|
|
|
Makefile |
1 | 12 years ago | kapil.foss at gmail | initial layout | 5.4 KB |
|
|
|
process.rst |
333 | 11 years ago | Brad Crittenden | Set version for release. | 17.3 KB |
|
|
|
readme.rst
|
218.1.1 | 11 years ago | Nicola Larosa | Add the README to the docs. | . |
|
|
|
style-guide.rst |
317.1.2 | 11 years ago | Nicola Larosa | Merge from trunk, three conflicts resolved. | 5.4 KB |
|
|