~benji/charms/precise/juju-gui/configurable-charmworld-url : changes

~benji/charms/precise/juju-gui/configurable-charmworld-url » Changes from revision 48

From Revision 48 to 29

Rev	Summary	Authors	Date
48	checkpoint checkpoint	Benji York	10 years ago
47	Reverted Node.js version back to 0.8.x Reverted Node.js version back to 0.8.x This is required because of a spritegen error which happens when we try to deploy the charm. R=gary.poster, bcsaller CC= https://codereview.appspot.com/8631048	Jeff Pihach	11 years ago
46	Convert charm back to using non-legacy node ppa Convert charm back to using non-legacy node ppa With reference to https://launchpad.net/~chris-lea/+ppa-packages . The only behavioral change is in the third chunk of hooks/utils.py , the rest is just code reformatting to appease Sublime Text, and some additional docstrings. R=frankban, gary.poster CC= https://codereview.appspot.com/8837048	Nicola Larosa	11 years ago
45	[TRIVAL] Apache Fallback resource [TRIVAL] Apache Fallback resource Missing resources return index.html with this single new directive. Thanks apache.	Benjamin Saller	11 years ago
44	[TRIVAL] Fix Apache site config [TRIVAL] Fix Apache site config Untested changes recommended in review don't work inside the VirtualHost directive. They are removed here as they were optional to being with.	Benjamin Saller	11 years ago
43	Apache support Apache support Change charm to use apache2 rather than nginx. Some additional cleanups around testing as well.	Benjamin Saller	11 years ago
42	Refactor Charm for Sandbox support Refactor Charm for Sandbox support This adds a composition system for creating backend object. Backend implement start(), stop() and install() methods. A backend is composed of many mixins and each mixin will implement any/of of those methods and all will be called. Backends additionally provide for collecting property values from each mixin into a single final property on the backend. There is also a feature for determining if configuration values have changed between old and new configurations so we can selectively take action. Using these features we add support for Sandbox'd deployments, limiting support for adding apt repositories and the ability to fetch a juju-gui release from a URL specified in a configuration property. R=gary.poster, matthew.scott CC= https://codereview.appspot.com/8727047	Benjamin Saller	11 years ago
41	No-op commit for publishing initial version using new mechan... No-op commit for publishing initial version using new mechanism	Gary Poster	11 years ago
40	merging trunk merging trunk	Jeff Pihach	11 years ago
39	reverting change to node 0.10 reverting change to node 0.10	Jeff Pihach	11 years ago
38	removed legacy ppa and removed unneeded npm dep removed legacy ppa and removed unneeded npm dep	Jeff Pihach	11 years ago
37	Added support for juju-core. Added support for juju-core. It is now possible to deploy the charm in a juju-core environment. The GUI correctly connects to the juju-core API server. R=gary.poster, bac CC= https://codereview.appspot.com/8081043	Francesco Banconi	11 years ago
36	Change to legacy node.js PPA to revert to 0.8 Change to legacy node.js PPA to revert to 0.8 R=bac CC= https://codereview.appspot.com/7759050	Jeff Pihach	11 years ago
35	Adjust config comments to align with juju-gui tweaks for sub... Adjust config comments to align with juju-gui tweaks for subapp support.	Rick Harding	11 years ago
34	add support for socket_protocol so that the websocket addres... add support for socket_protocol so that the websocket address can be generated dynamically in the browser for greater deployment flexibility (such as canonistack), while maintaining backwards compatibility with earlier GUI releases. Note that, as of this writing, you need to use lp:juju-gui (trunk) to make this dynamic addressing work. add ability to deploy insecurely (http/ws), in order to facilitate CI tests add tests for new functionality update documentation speed up default deployment by only getting staging dependencies when needed, and only getting build dependencies when needed (bug 1117896). On EC2, this speeds up the default deployment (from release) by about 2.5 minutes. work around backward incompatibility in update to charmhelpers' log function. increase timeout for tests to make them pass more often	Gary Poster	11 years ago
33	Handle browser warning dialog in deploy tests. Handle browser warning dialog in deploy tests. This branch fixes the test failures caused by Firefox not being able to handle the "your browser is not supported" dialog. Also updated the charm testing branch, including the latest stable release (v0.2.1): see http://bazaar.launchpad.net/~juju-gui/juju-gui/charm-tests-branch/files R=gary.poster, teknico CC= https://codereview.appspot.com/7398057	Francesco Banconi	11 years ago
32	Add and use a log_hook context manager. Add and use a log_hook context manager. Replace the current calls to log_entry and log_exit in the __main__ of the hooks with a log_hook context manager, simplifying the code a bit. Avoiding log_entry and log_exit also temporarily works around a problem they have with the juju-core handling of strings starting with "--" in juju-log. R=gary.poster CC= https://codereview.appspot.com/7379050	Francesco Banconi	11 years ago
31	Add an option to start test server. Add an option to start test server. Added the "serve-tests" option to the charm, defaulting to False. When the option is enabled it is possible to run the Juju GUI unit tests using https://[sevice url]/test/. I needed to conditionally add the corresponding location to the nginx configuration file. I discussed with Gary about possible ways to achieve this. Using the standard Python string substitution seemed hacky, and the resulting template file could be less readable. We decided to start using a templating library: ended up with tempita because it is lightweight and it is already used in maas. nginx is now configured so that the /test/ location: - serves unit tests if "serve-tests" is True; - redirects to / if "serve-tests" is False. The latter is required because otherwise the test location would be added to the browser appcache: the index.html file would be served and it references the manifest file. Also fixed dependency management in the install hook. Now all the Python libraries required by the charm are installed at the beginning of the process, before utils, launchpadlib, tempita etc. are imported. QA: - deploy the charm; - juju set juju-gui serve-tests=true; - go to "https://[sevice url]/test/"; - you should see tests run (mocha html reporter). Problems: test-debug (staging=true) fails to run because it attempts to load external (insecure) resources. Filed bug #1116320. R=gary.poster, teknico CC= https://codereview.appspot.com/7306045	Francesco Banconi	11 years ago
30	Serve HTTPS and WebSocket on the same port. Serve HTTPS and WebSocket on the same port. The WebSocket connection must be established on port 443, so that using Firefox securely no longer requires the user to accept a self-signed certificate twice: once for the HTTPS port and once for the wss port. HAProxy is used to do that: juju-gui/ppa contains the development release of HAProxy, supporting SSL. HTTPS traffic is sent to nginx (port 8000), and wss connections are redirected to the underlaying API backend (port 8080). The juju-api-port option has been removed: since that port is no longer exposed, the one being used can be considered just an internal implementation. Other changes: Updated documentation. Moved static upstart configuration files set up to the install hook. This way, a config change no longer causes them to be rewritten as they are over and over. Some renaming and clean up. QA: - deploy the charm - open the application using Firefox - add the security exception - you should see the Juju GUI login screen - now try staging: juju set juju-gui staging=true - compulsively refresh Firefox - admire the services R=gary.poster, teknico CC= https://codereview.appspot.com/7253043	Francesco Banconi	11 years ago
29	Fixes for bug #1103035. Fixes for bug #1103035. Add the "curl" package as an install dependency: some OS images may not include it by default. Remove the "user" and "password" options from the "config.yaml" file. Those credentials are easily discoverable and insecure. The code still hardwires bypassing the authenticating step when deploying to staging. Move the "maintainer" line to below the "summary" one in "metadata.yaml". README file: - list the currently supported web browsers; - explain the self-signed certificate workaround currently needed to make Firefox work; - anonymize the EC2 addresses. R=gary.poster, matthew.scott CC= https://codereview.appspot.com/7205044	Francesco Banconi	11 years ago

Older »