Viewing all changes in revision 236.
- Committer: Matthew Scott
- Date: 2012-11-09 21:27:16 UTC
- mfrom: (223.4.6 replace-service-module)
- Revision ID: matthew.scott@canonical.com-20121109212716-o9xv6d3cbvclvcq8
Lightweight assets/improve FF performance
Some lighter weight assets for service modules were implemented, via Matt C. Additionally, profiling showed that a lot of slowness for FireFox was caused by FF internals being slow (namely <node>.setAttribute() and <node>.getClientRects()). While we can't fix those being slow, we can reduce the number of times they're used. This is done by modifying attributes on only relevant relation lines when a service is dragged (rather than redrawing or modifying all lines). This results in fewer calls to both of those internals, and speeds up animation in FireFox.
R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6826057
Some lighter weight assets for service modules were implemented, via Matt C. Additionally, profiling showed that a lot of slowness for FireFox was caused by FF internals being slow (namely <node>.setAttribute() and <node>.getClientRects()). While we can't fix those being slow, we can reduce the number of times they're used. This is done by modifying attributes on only relevant relation lines when a service is dragged (rather than redrawing or modifying all lines). This results in fewer calls to both of those internals, and speeds up animation in FireFox.
R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6826057
expand all
collapse all
added
removed
app/assets/svgs/service_health_mask.svg
app/assets/svgs/service_module.svg
