~bestpractical/rt/4.4

Viewing all changes in revision 8749.

  • Committer: sunnavy
  • Date: 2020-08-14 20:42:46 UTC
  • Revision ID: git-v1:31ca5c2ab297d4593102e6fb28f5ae18644109d0
Fix wrongly duplicated one-time addresses on ticket update page

When user clicks address checkboxes below one-time inputs, RT will
add/remove corresponding addresess to/from the corresponding one-time
inputs, and when it's done, UpdateIgnoreAddressCheckboxes will be set to
true to indicate RT to ignore those checkboxes at backend as they are
already synced to one-time inputs.

It didn't consider the case where people may submit form a few times
before really updating the ticket, e.g. via searching/selecting
articles, adding more attachments(the old UI), etc. If we don't keep the
submitted UpdateIgnoreAddressCheckboxes value, it could be finally
submitted with value 0 and RT will wrongly handle those checkboxes at
backend, which could cause duplicated Cc/Bcc email addresses in outgoing
emails.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: