~blue-shell/blue-shell/baloo : changes

~blue-shell/blue-shell/baloo » Changes from revision 1701

From Revision 1701 to 1682

Rev	Summary	Authors	Date
1701	Fix build Fix build The generated header containing the necessary bits for categorized logging was never included. CCMAIL: stefan.bruens@rwth-aachen.de	Luca Beltrame	4 years ago
1700	[SearchStore] Use categorized logging [SearchStore] Use categorized logging Test Plan: no functional changes Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: apol, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28501	Stefan Brüns	4 years ago
1699	[QueryParser] Fix broken detection of end quote [QueryParser] Fix broken detection of end quote Summary: In case the a closing quote was not followed by any term, but only whitespace, punctuation or other ignored characters (or any mixture thereof), the quote would not be detected. Test Plan: ctest -R queryparser Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28506	Stefan Brüns	4 years ago
1698	[EngineQuery] Provide toString(Term) overload for QTest [EngineQuery] Provide toString(Term) overload for QTest Summary: Without the overload QTest only provides the generic "Compared values are not the same" message, without any details. Also make the debug output more compact. Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28505	Stefan Brüns	4 years ago
1697	[EngineQuery] Remove unused position member, extend tests [EngineQuery] Remove unused position member, extend tests Summary: The "pos" member is unused, remove it from the EngineQuery class. Test Plan: ctest $> baloosearch foo png -> finds foo.png and foo_bar.png $> baloosearch foo.png -> still finds foo.png, but not foo_bar.png Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28504	Stefan Brüns	4 years ago
1696	[Term] Make debug output more compact and nicer to read [Term] Make debug output more compact and nicer to read Summary: Do not print the property name if it is not specified (i.e. the default). Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28503	Stefan Brüns	4 years ago
1695	[SearchStore] Avoid long lines and function nesting [SearchStore] Avoid long lines and function nesting	Stefan Brüns	4 years ago
1694	[baloosearch] Bail out early if specified folder is not vali... [baloosearch] Bail out early if specified folder is not valid Test Plan: $> baloosearch -d /foo "test" /foo is not a valid directory Reviewers: #baloo, ngraham, apol Reviewed By: apol Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28502	Stefan Brüns	4 years ago
1693	Fix compile Fix compile	Ömer Fadıl USTA	4 years ago
1692	[MTimeDB] Consolidate time interval handling code [MTimeDB] Consolidate time interval handling code Summary: There are two places where half-bounded time intervals with [<=,<,==,>,>=] are handled, once in the SearchStore, and once in the MtimeDB itself (where the latter only has [<=,==,>=]). Remove the handling from the MtimeDB and only keep the one in the SearchStore. Test Plan: ctest -V -R mtimedbtest Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28396	Stefan Brüns	4 years ago
1691	[AdvancedQueryParser] Test if quoted phrases are passed corr... [AdvancedQueryParser] Test if quoted phrases are passed correctly Test Plan: ctest -V -R advancedqueryparsertest Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28394	Stefan Brüns	4 years ago
1690	[Term] Provide toString(Term) overload for QTest [Term] Provide toString(Term) overload for QTest Summary: Without the overload QTest only provides the generic "Compared values are not the same" message, without any details. Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28393	Stefan Brüns	4 years ago
1689	[ResultIterator] Remove unneeded SearchStore forward declara... [ResultIterator] Remove unneeded SearchStore forward declaration Summary: SearchStore is not even exported, while ResultIterator is. Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28392	Stefan Brüns	4 years ago
1688	[QueryTest] Make phrase test case data driven and extend [QueryTest] Make phrase test case data driven and extend Summary: Check if also filenames are matched by phrase queries. Add toString debug helper to get a more meaningful failure output. Test Plan: ctest -V -R querytest Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28387	Stefan Brüns	4 years ago
1687	[Extractor] Delay mimetype check, cleanup debug output [Extractor] Delay mimetype check, cleanup debug output Summary: In case a file is skipped by a name filter there is no need to determine the mimetype (which is costly, as a content based mimetype is used here). Avoid multiple debug messages per file, only issue "Indexing ..." in case the file is not skipped. All "Skipping ..." paths have a distinct. debug/warning message. Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28384	Stefan Brüns	4 years ago
1686	[Inotify] Start the MoveFrom expire timer at most once per i... [Inotify] Start the MoveFrom expire timer at most once per inotify batch Summary: We may get several MoveFrom/MoveTo events per read. If we are lucky, we get complete pairs for renames and the cookie list is empty, then there is no need to start the timer at all. Avoid indefinite process delays of unpaired MoveFrom events by new MoveFrom events. Restart the timer only if not already active, and process all events when a 1 second deadline has passed. Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28327	Stefan Brüns	4 years ago
1685	[BasicIndexingJob] Remove unused include [BasicIndexingJob] Remove unused include Summary: GIT_SILENT Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28352	Stefan Brüns	4 years ago
1684	[UnindexedFileIndexer] Only mark file for content indexing w... [UnindexedFileIndexer] Only mark file for content indexing when needed Summary: In case the index level is set to "non content indexing", the file was still flagged when it had changed. As the content indexer checks for the level itself (the config may have changed in the meantime), the effect is limited, but the code is still wrong. In case the level is set to "content indexing", the flag would be set twice. As it is a flag the effect is limited, but it blows up the transaction unnecessarily. Reviewers: #baloo, ngraham, davidedmundson Reviewed By: #baloo, ngraham, davidedmundson Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28326	Stefan Brüns	4 years ago
1683	[Inotify] Call QFile::decode only in a single place [Inotify] Call QFile::decode only in a single place Summary: Most events need a decoded path, so move it to the front. As only one flag per event can be set the decoding only happens once, but it removes the duplicated QFile::decode() calls from the object code. Reviewers: #baloo, ngraham Reviewed By: #baloo, ngraham Subscribers: kossebau, apol, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28325	Stefan Brüns	4 years ago
1682	[QML] Correctly watch for unregistration [QML] Correctly watch for unregistration Summary: We wont get the serviceUnregistered signal if only the WatchForRegistration flag is set. Remove the unused service name from the balooStarted method. Test Plan: 1. start kinfocenter 2. balooctl disable Reviewers: #baloo, ngraham, davidedmundson Reviewed By: davidedmundson Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D28288	Stefan Brüns	4 years ago

Older »