|
409.1.2
by Ted Gould
Adding merge review policy |
1 |
This documents the expections that the project has on what both submitters |
2 |
and reviewers should ensure that they've done for a merge into the project. |
|
3 |
||
4 |
== Submitter Responsibilities == |
|
5 |
||
6 |
* Ensure the project compiles and the test suite executes without error |
|
7 |
* Ensure that non-obvious code has comments explaining it |
|
8 |
* If the change works on specific profiles, please include those in the merge description. |
|
9 |
||
10 |
== Reviewer Responsibilities == |
|
11 |
||
12 |
* Did the Jenkins build compile? Pass? Run unit tests successfully? |
|
13 |
* Are there appropriate tests to cover any new functionality? |
|
14 |
* If the description says this effects the phone profile: |
|
15 |
* Run tests indicator-sound/unity8* |
|
16 |
* If the description says this effects the desktop profile: |
|
17 |
* Run tests indicator-sound/unity7* |
|
18 |
||
19 |