~cmars/juju-core/local-repo-errmsg : changes

~cmars/juju-core/local-repo-errmsg » Changes from revision 1151.1.1

From Revision 1151.1.1 to 1133

Rev	Summary	Authors	Date
1151.1.1	Trivial rename of trivial -> utils. Trivial rename of trivial -> utils.	Tim Penhey	11 years ago
1151	environs: extract tools package environs: extract tools package This is much simpler than it looks. Motivation is as follows: 1) I'm trying to make our tools logic consistent, so we have some sort of chance of different parts of the system acting in concert (bootstrap, start-instance, sync-tools, upgrade-juju, juju upgrades, ...?). It is currently very difficult to build a mental model of how these things are related, and a common vocabulary will help. 2) I'd be crazy to try to do everything at once (ha!). So I'll leave the existing tools selection logic (FindTools, BestTools) in place while I focus on just uploads/downloads. 3) Move tool-storagey code from environs to environs/tools: * environs.listTools -> tools.ReadList (environs.ListTools now uses tools.ReadList) * environs.PutTools -> tools.Upload (lots of code moved to storage.go and build.go in tools/) * environs.ToolsStoragePath -> tools.StorageName (it's a name, not a path, according to the storage metaphor) ...hmm. Lots of renames. 4) But wait, I can't do this, I need to use environs.Storage, and there's an import loop. To keep the diff small, define tools.URLLister and tools.URLPutter. 6) The tests are starting to look somewhat repetitive, and I fear subtle differences creeping in. Let's bulk up environs/testing a little. Ah, that's better. From a review perspective, this branch is largely mechanical. The only code that is new, as opposed to moved or mechanically replaced, is: * the tests for tools.ReadList (made explicit now it's exported). * the tests for environs.EmptyStorage (yes, it's trivial. yes, it should still be tested.) * environs/testing/tools.go (mostly new, and used in several places). * UpgradeJujuCommand (surprising behaviour corrected, clarifying test added). R=thumper, dimitern CC= https://codereview.appspot.com/8545043	William Reade	11 years ago
1150	[author=allenap,jtv,julian-edwards,rvb][r=fwereade,julian- [author=allenap,jtv,julian-edwards,rvb][r=fwereade,julian-edwards,allenap,jtv,rvb] MAAS provider (feature branch).	Jeroen Vermeulen	11 years ago
1149	deuglify logging for main packages. deuglify logging for main packages. Removed "cmd/juju*: " badge from all commands. Also remove the "JUJU:" prefix and the automatic command prefix and name which was just repeating what's already in the message itself. So now, instead of: ERROR JUJU:jujutest:blah jujutest blah command failed: BAM! ERROR JUJU:juju:bootstrap juju bootstrap command failed: dummy.Bootstrap is broken INFO JUJU:test hello We'll have just: ERROR command failed: BAM! INFO hello ERROR command failed: dummy.Bootstrap is broken The timestamp with format like 2013/04/12 09:59:16 is still there, before the message. R=rog, dfc CC= https://codereview.appspot.com/8674043	Dimiter Naydenov	11 years ago
1148	various: unify machine and unit status types various: unify machine and unit status types Trivial change to simplify the code by unifying machine and unit status type to params.Status, rather than two separate types and separate list of constants. R=fwereade, rog CC= https://codereview.appspot.com/8667043	Dimiter Naydenov	11 years ago
1147	state/api: enable authentication state/api: enable authentication R=fwereade, dfc CC= https://codereview.appspot.com/8626044	Roger Peppe	11 years ago
1146	state/api: add Constraints to AllWatcher state/api: add Constraints to AllWatcher R= CC= https://codereview.appspot.com/8568044	Roger Peppe	11 years ago
1145	cmd/juju: status displays machine errors cmd/juju: status displays machine errors This makes the juju status command behave in a more py-juju compatible way, displaying the following additional information for each machine: agent-state: [whatever machine.Status() reports] agent-state-info: [machine.Status().Info, if set] "instance-state" is not possible to support right now, so I didn't implement it, but filed a lp:1167441 bug. Also, when the agent is detected as "down", the agent-state-info shows the original status and the info (if set). Finally, there is a fix for the machiner to handle SetAgentAlive() and testing it correctly. R=rog, fwereade CC= https://codereview.appspot.com/8561046	Dimiter Naydenov	11 years ago
1144	worker/machiner: set status and agent alive worker/machiner: set status and agent alive The machiner will now set the machine status as needed (started/stopped), log the actions with Noticef, and SetAgentAlive(), as required. R=fwereade, rog CC= https://codereview.appspot.com/8630043	Dimiter Naydenov	11 years ago
1143	source mongo from package source mongo from package This proposal replaces the source of mongo for state servers. Mongo is now installed from a package. The source of this package differs depending on the series of the machine being bootstrapped (which is itself drawn from the tools installed on the machine). For P and Q, the source is a PPA owned by the Juju team. For R and above, mongo is available in the archive. R=rog, dimitern, fwereade CC= https://codereview.appspot.com/8648043	Dave Cheney	11 years ago
1142	Implement the set-environment command. Implement the set-environment command. This change introduces a new command called set-environment. It has an alias of set-env, and is the pair to get-environment. Key/value pairs are taken on the command line as positional parameters. The environment is retrieved from state, updated with the new values, and then validated using the provider Validate method. The resulting configuration is passed bach through to the state.SetEnvironConfig. There are some standard config values that we really don't want changing. These rules have been encoded in a new function config.Validate. This is now called from each of the provider validate methods. I added a non-exported helper method on Config to do the type coersion for getting values from the known map. This is now used in many internal places. Since the agent-version was always added in the config.New to be the default value, I instead add this to the schema default values. The existing tests make sure this still works as intended. Added an extra test for backslashes in names. Moved the firewall-mode default behaviour up into the base class, as it was identical in all three provider validate methods. R=fwereade, dfc CC= https://codereview.appspot.com/8610043	Tim Penhey	11 years ago
1141	Add a get-environment command. Add a get-environment command. Be able to get environment values from state. You can ask for either a single value, or get the whole lot formatted how you like (well within reason). set-environment coming next. R=dfc, dimitern, fwereade CC= https://codereview.appspot.com/8597045	Tim Penhey	11 years ago
1140	environs/tools: new package environs/tools: new package Tools selection logic implemented for `juju sync-tools` moved into its own package, and was expanded somewhat. R=dfc, thumper, rog, TheMue, dimitern CC= https://codereview.appspot.com/8604043	William Reade	11 years ago
1139	juju: remove dependency on api/params juju: remove dependency on api/params The juju package should really not depend on api/params if possible. We move two functions into State and delete the now-redundant statecmd shim functions. We also fix bug 1167344 in passing. The only logic change in this branch is to remove "no options to set" check from Service.Set. IMHO setting no options should be acceptable. R=fwereade, dimitern CC= https://codereview.appspot.com/8626043	Roger Peppe	11 years ago
1138	cmd/jujud: fix MachineSuite cmd/jujud: fix MachineSuite It wouldn't work when the machine tests were run in isolation. R=fwereade CC= https://codereview.appspot.com/8616044	Roger Peppe	11 years ago
1137	finish nonced provisioning finish nonced provisioning Now the provisioner uses all that was done in the previous CLs and brings it together: generating an unique nonce at StartInstance time and passing that to SetProvisioned as well. MA.Entity now returns ErrTerminateAgent when the machine is not provisioned. The nonce is generated using trivial.NewUUID(), badged with the machine tag the provisioner is running on (the machine id is now passed to NewProvisioner). Also, TestUUID in trivial was extracted into its own test module. Added IsValidUUIDString() and UUIDFromString() -> UUID, error to uuid.go, and tests. R=fwereade, TheMue CC= https://codereview.appspot.com/8620043	Dimiter Naydenov	11 years ago
1136	state: add nonced provisioning support state: add nonced provisioning support Next step in nonced provisioning; adding support in state: machine.SetInstanceId() renamed to SetProvisioned(), taking instance id and nonce. It allows you change it only once, so some tests that assumed too much had to be changed (e.g. changing instance id several times just to trigger a machine change). Also CheckProvisioned() is added to machine, taking a nonce and returning true is returned only when the instance id is set and the nonce matches. In the upcoming CL we'll bring everything together - PA generating an unique nonce, and checking it. R=fwereade, TheMue, rog, dfc CC= https://codereview.appspot.com/8561044	Dimiter Naydenov	11 years ago
1135	publish: test charm locally before publishing publish: test charm locally before publishing R= CC= https://codereview.appspot.com/8578045	Gustavo Niemeyer	11 years ago
1134	Refactor environs/openstack/config_test.go Refactor environs/openstack/config_test.go Clean up OpenStack config_test.go to define all the tests using configTests array, including those that override environment variables. R=dimitern, niemeyer CC= https://codereview.appspot.com/8584043	Данило Шеган	11 years ago
1133	charm: use functions for validation charm: use functions for validation R=dimitern, danilo.segan CC= https://codereview.appspot.com/8585043	Gustavo Niemeyer	11 years ago

Older »