~compiz-team/compiz/compiz.fix_1085591

Viewing all changes in revision 3512.

  • Committer: Sam Spilsbury
  • Date: 2012-12-05 03:45:59 UTC
  • Revision ID: sam.spilsbury@canonical.com-20121205034559-nx1fka0tv3shejvg
Don't destroy wmSnSelectionWindow on shutdown.

Because we haven't changed our active event mask
to remove SubstructureRedirectMask, other ICCCM
compliant window managers may receive a DestroyNotify
(eg, because we're blocked on XSync) before we get
a chance to close our display connection and remove
our SubstructureRedirectMask. That will cause them
to fail to start.

The selection window is destroyed anyways when we
close our connection, and that is a very accurate
indicator to other WM's that we are well and truly
gone because the protocol requires the implementation
to remove all client event masks before destroying
windows.

Now ReplaceOtherWMSlow doesn't seem to fail at all
because "another WM was running"

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: