~connman-maintainers/connman/head : changes

~connman-maintainers/connman/head » Changes from revision 8400

From Revision 8400 to 8381

Rev	Summary	Authors	Date
8400	service: Make DBG in '__connman_service_ipconfig_indicate_st... service: Make DBG in '__connman_service_ipconfig_indicate_state' consistent. This makes the DBG statement in '__connman_service_ipconfig_indicate_state' consistent in format of 'service <service_pointer> (<service_name>) type <ipconfig_type> (<ipconfig_type_name>)' with that of other DBG statements in the module. This makes at-a-glance, columnar correlation and comparison of service activities easier.	Grant Erickson	4 days ago
8399	service: Add documentation to 'address_updated'. service: Add documentation to 'address_updated'. This adds documentation to the 'address_updated' function.	Grant Erickson	4 days ago
8398	service: Add DBG statement to 'address_updated'. service: Add DBG statement to 'address_updated'. This adds a DBG statement to 'address_upated' to aid in debugging.	Grant Erickson	4 days ago
8397	service: Leverage 'connman_service_is_default'. service: Leverage 'connman_service_is_default'. This leverages the recently-added 'connman_service_is_default' in 'address_updated' rather than duplicating the same logic from the former in the latter.	Grant Erickson	4 days ago
8396	service: Document '{clear,set}_error'. service: Document '{clear,set}_error'. This adds documentation to the '{clear,set}_error' functions.	Grant Erickson	6 days ago
8395	service: Add and leverage 'clear_error'. service: Add and leverage 'clear_error'. There are a suffient number of instantiations of the following implementation pattern: set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN); to clear or reset the "Error" service property where it makes sense to embody this in a single function, 'clear_error'. This introduces and leverages the 'clear_error' function to embody this pattern.	Grant Erickson	6 days ago
8394	service: Document 'handle_online_check_{failure,success}'. service: Document 'handle_online_check_{failure,success}'. This adds documentation to the 'handle_online_check_{failure,success}' functions.	Grant Erickson	6 days ago
8393	service: Bifurcate 'complete_online_check' handling. service: Bifurcate 'complete_online_check' handling. This bifurcates 'complete_online_check' closure handling into a success and failure handler: 'handle_online_check_success' and 'handle_online_check_failure'. Both at present and as the continuous online check mode (also known as, 'EnableOnlineToReadyTransition') evolves, the closure handling of online checks is both more tractable and easier to reason about when partitioned into success and failures rather than co-mingling both into the same function. Moreover, it simplifies 'complete_online_check' itself.	Grant Erickson	6 days ago
8392	service: Group online check state by IP configuration type. service: Group online check state by IP configuration type. As the implementation of the continuous online check mode (also known as, EnableOnlineToReadyTransition) evolves, there is an increasing need for spatial locality of online check state by IP configuration type. Consequently, rather than having a collection of individual data members in the service structure decorated with '_ipv4' and '_ipv6' and accessing them one-by-one, group them into a common structure. Then, instantiate that structure twice in the service structure, once for IPv4 and once for IPv6. This allows for the desired spatial locality.	Grant Erickson	6 days ago
8391	service: Document the 'current_default' global. service: Document the 'current_default' global. This documents the 'current_default' global and includes "see also" references to related functions.	Grant Erickson	6 days ago
8390	service: Const-qualify 'connman_service_get_interface'. service: Const-qualify 'connman_service_get_interface'. Const-qualify the network service argument to make it clear to the compiler, static analyzers, and human readers that the function is strictly a getter with no network service mutation side effects.	Grant Erickson	6 days ago
8389	service: Leverage 'connman_service_set_proxy_method'. service: Leverage 'connman_service_set_proxy_method'. Previously, inside 'check_proxy_method', if WPAD failed for any reason the code would explicitly manipulate the 'proxy' field of the service object and then invoke '__connman_notifier_proxy_changed'. However, when 'method' is 'CONNMAN_SERVICE_PROXY_METHOD_DIRECT', which is the case in 'check_proxy_method', this is 2/3 of what 'connman_service_set_proxy_method' already does. The 1/3 difference is that 'connman_service_set_proxy_method' calls 'proxy_changed'. Consequently, since there does not seem to be a well-documented or compelling reason to avoid the call to 'proxy_changed', simply leverage and call 'connman_service_set_proxy_method' from 'check_proxy_method' to set the service proxy method to 'CONNMAN_SERVICE_PROXY_METHOD_DIRECT' when WPAD fails.	Grant Erickson	6 days ago
8388	service: Leverage '__connman_wispr_cancel'. service: Leverage '__connman_wispr_cancel'. This leverages the newly-introduced '__connman_wispr_cancel' in 'cancel_online_check' to ensure that a pending or in-flight WISPr portal detection request or an "online" HTTP-based Internet reachability check is canceled not only in the service module but in the WISPr module as well. This prevents two concurrent, outstanding, and redundant IPv4 WISPr requests from being in-flight when 'EnableOnlineCheck' is asserted. Prior to this change, this redundancy was set in motion by: 1. The two back-to-back IPv4 probes get triggered by both of the following paths: a. Triggered from 'default_changed' and 'start_wispr_if_connected'. This is the newer path, chronologically, in the code base. b. Triggered from 'service_ip_bound', 'address_updated', and 'start_online_check'. This is the older path, chronologically, in the code base. 2. With the following commits addressed: a. 812e171 ("Close three '__connman_wisp_start' failure closure holes.") * With this fix alone, at minimum, the first probe above (1) would have resulted, eventually in a failure closure with 'complete_online_check'. b. 5f95851 ("wispr: Avoid 'connman_proxy_lookup' call for UNKNOWN proxy method.") fixed, the first IPv4 probe from (1) no longer "falls down a 'hole'" and gets lost (closure- and accounting- wise). * With this fix, the first IPv4 probe is no longer a complete throwaway--it actually succeeds. However, since it does so, it becomes the first of the two redundant IPv4 checks. By employing '__connman_wispr_cancel', 'cancel_online_check' quells the first IPv4 check triggered from 'default_changed' and 'start_wispr_if_connected' and replaces it, fully (in BOTH the service and WISpr modules), with the second IPv4 check triggered from 'service_ip_bound', 'address_updated', and 'start_online_check'.	Grant Erickson	6 days ago
8387	wispr: Avoid double-free in 'free_wispr_routes'. wispr: Avoid double-free in 'free_wispr_routes'. Now that 'free_wispr_routes' can be invoked in terminal free-only as well as cancel-latently-followed-by-free contexts, ensure that a double-free is avoided with both the 'route->address' and 'wp_context->route_list->data' by explicitly nulling them after calling 'g_free' on them.	Grant Erickson	6 days ago
8386	wispr: Add documentation to '__connman_wispr_cancel'. wispr: Add documentation to '__connman_wispr_cancel'. This adds documentation to the '__connman_wispr_cancel' function.	Grant Erickson	6 days ago
8385	wispr: Add '__connman_wispr_cancel' interface. wispr: Add '__connman_wispr_cancel' interface. This adds a heretofore-missing '__connman_wispr_cancel' interface. It attempts to cancel a HTTP-based Internet reachability check for the specified network service IP configuration type. If a matching WISPr portal detect request or HTTP-based Internet reachability check is found, the original callback specified with '__connman_wispr_start' will be invoked with a success value of zero ('0') or false and an error value of -ECANCELED.	Grant Erickson	6 days ago
8384	gweb: Factor out GWeb destruction into 'g_web_free'. gweb: Factor out GWeb destruction into 'g_web_free'. This factors out the destruction of a GWeb object into 'g_web_free' to make it clearer, during debugging and development, when destruction of the reference-counted object actually occurs and which aspects of the object are being destroyed.	Grant Erickson	6 days ago
8383	gweb: Add reference count debug statements. gweb: Add reference count debug statements. This adds reference count debugging statements in 'g_web_ref' and 'g_web_unref', similar but not identical to other modules in the project.	Grant Erickson	6 days ago
8382	service: Add IP configuration type to 'cancel_online_check'. service: Add IP configuration type to 'cancel_online_check'. WISPr / portal detection and HTTP-based "online" Internet reachability checks are, by design, IP configuration-specific. There may be parallel, independent requests or checks in flight: one for IPv4 and one for IPv6. Consequently, when attempting to cancel such requests or checks, require the IP configuration type to indicate which specific request or check is to be canceled.	Grant Erickson	6 days ago
8381	wispr: Add and leverage an OS error parameter to '__connman_... wispr: Add and leverage an OS error parameter to '__connman_wispr_cb_t'. This adds and leverages an operating system error parameter to '__connman_wispr_cb_t' such that such callbacks can leverage the error status when 'success' is false to either log the status or take conditional action.	Grant Erickson	6 days ago

Older »