~corey.bryant/charm-helpers/os-release-cache

Viewing all changes in revision 783.

  • Committer: Alex Kavanagh
  • Date: 2017-08-15 10:09:15 UTC
  • mfrom: (782.1.1 fix-gpg)
  • Revision ID: alex.kavanagh@canonical.com-20170815100915-0bnw0c54r7nd2w8i
[stub, r=tinwood] A feature of the PostgreSQL charm had stopped working, as
charm-helpers was attempting to do more validation of GPG key formats and the
PG charm happens to add comments to its keys so they don't get mixed up.

While fixing this, noticed that insecure usage still seems to be promoted.
Clearly flag this cases in the docstring and add WARNING messages to logs when
people open themselves up to attack (the key retrieval protocol is unencrypted
for historical reasons and the same man-in-the-middle attack that poisons an
archive can also make people trust keys retrieved this way).

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: