← Back to branch summary

~cprov/uci-engine/webui-native-tickets

« back to all changes in this revision

Viewing changes to webui/tickets/static/tickets/webuiforms.js

  • Committer: Ubuntu CI Bot
  • Author(s): Paul Larson
  • Date: 2014-12-17 22:09:18 UTC
  • mfrom: (904.3.8 required-fields)
  • Revision ID: ubuntu_ci_bot-20141217220918-dp9audsus027beor
Add a webui error messages when required fields are left empty. [r=Francis Ginther, Paul Larson]

Show diffs side-by-side

added added

removed removed

Lines of Context:
webui/tickets/static/tickets/webuiforms.js
135
135
                    {name: 'title', required: true, label: 'Title:'},
136
136
                    {name: 'description', label: 'Description:',
137
137
                     type: 'TextareaField'},
138
 
                    {name: 'owner', required: true, label: 'Owner:',
 
138
                    {name: 'owner', label: 'Owner:',
139
139
                     validator: Y.FormField.VALIDATE_EMAIL_ADDRESS},
140
 
                    {name: 'landers', label: 'Landers:'},
 
140
                    {name: 'landers', required: true, label: 'Landers:'},
141
141
                    {name: 'qa_review', label: 'QA sign-off required?',
142
142
                     type: 'CheckboxField'},
143
143
                    {name: 'sync_request', label: 'Sync request:'},
149
149
                    {name: 'merge_proposals', label: 'Merge Proposals:',
150
150
                     validator: Y.webuiforms.validateMP,
151
151
                     type: 'TextareaField'},
152
 
                    {name: 'test_notes', label: 'Test notes:',
 
152
                    {name: 'test_notes', required: true, label: 'Test notes:',
153
153
                     type: 'TextareaField'},
154
154
                    {name: 'comments', label: 'Comments:',
155
155
                     type: 'TextareaField'},
173
173
                    return 1;
174
174
                }
175
175
 
 
176
                var sources_field = Y.one(
 
177
                    'textarea[name="sources"]').get('value');
 
178
                var merges_field = Y.one(
 
179
                    'textarea[name="merge_proposals"]').get('value');
 
180
                if (sources_field === "" && merges_field === "") {
 
181
                    f.getField('sources').set('error',
 
182
                        'Source Packages or Merge Proposals must be supplied');
 
183
                    f.getField('merge_proposals').set('error',
 
184
                        'Source Packages or Merge Proposals must be supplied');
 
185
                    return 1;
 
186
                }
 
187
 
176
188
                var form_data = f.toJSON();
177
189
                form_data = Y.webuiforms._mangleFormSources(form_data);
178
190
                form_data = Y.webuiforms._mangleFormCitrain(form_data);
258
270
                method : 'post',
259
271
                children : [
260
272
                    {name: 'title', required: true, label: 'Title:'},
261
 
                    {name: 'owner', required: true, label: 'Owner:',
 
273
                    {name: 'owner', label: 'Owner:',
262
274
                     validator: Y.FormField.VALIDATE_EMAIL_ADDRESS},
263
 
                    {name: 'landers', label: 'Landers:'},
 
275
                    {name: 'landers', required: true, label: 'Landers:'},
264
276
                    {name: 'bug_id', label: 'Bug id:',
265
277
                     validator: Y.webuiforms.validateBugId,
266
278
                     validateInline: true},
272
284
                     type: 'TextareaField'},
273
285
                    {name: 'description', label: 'Description:',
274
286
                     type: 'TextareaField'},
275
 
                    {name: 'test_notes', label: 'Test notes:',
 
287
                    {name: 'test_notes', required: true, label: 'Test notes:',
276
288
                     type: 'TextareaField'},
277
289
                    {name: 'comments', label: 'Comments:',
278
290
                     type: 'TextareaField'},
340
352
                if (!f._runValidation()) {
341
353
                    return 1;
342
354
                }
 
355
 
 
356
                var sources_field = Y.one(
 
357
                    'textarea[name="sources"]').get('value');
 
358
                var merges_field = Y.one(
 
359
                    'textarea[name="merge_proposals"]').get('value');
 
360
                if (sources_field === "" && merges_field === "") {
 
361
                    f.getField('sources').set('error',
 
362
                        'Source Packages or Merge Proposals must be supplied');
 
363
                    f.getField('merge_proposals').set('error',
 
364
                        'Source Packages or Merge Proposals must be supplied');
 
365
                    return 1;
 
366
                }
 
367
 
343
368
                var form_data = f.toJSON();
344
369
                form_data = Y.webuiforms._mangleFormSources(form_data);
345
370
                form_data = Y.webuiforms._mangleFormCitrain(form_data);