~ctwm/ctwm/trunk : changes

~ctwm/ctwm/trunk » Changes from revision 641.1.43

Rev	Summary	Authors	Date
641.1.23	Change InitVariables() so it actually does the allocation of... Change InitVariables() so it actually does the allocation of the ScreenInfo and returns it. Rename to match.	Matthew Fuller	6 years ago
641.1.22	Change InitVariables() to do a little more of the early Change InitVariables() to do a little more of the early initialization, move it earlier in the file, and pull out the code setting colors (which now relies on stuff happening after it's called).	Matthew Fuller	6 years ago
641.1.21	Move calling the OTP init out of InitVariables() and into th... Move calling the OTP init out of InitVariables() and into the main flow.	Matthew Fuller	6 years ago
641.1.20	Instead of setting all these cursors at the start, then poss... Instead of setting all these cursors at the start, then possibly overriding them in the config parsing, let the config parsing run and then default any that weren't set.	Matthew Fuller	6 years ago
641.1.19	make indent make indent	Matthew Fuller	6 years ago
641.1.18	Get rid of these FreeList() calls. They're noops when they'... Get rid of these FreeList() calls. They're noops when they're passed something NULL, and this is right after calloc()'ing Scr, so they're all NULL anyway.	Matthew Fuller	6 years ago
641.1.17	Leave a comment about an interesting open question. Leave a comment about an interesting open question.	Matthew Fuller	6 years ago
641.1.16	We already set this before this func even gets called. We already set this before this func even gets called.	Matthew Fuller	6 years ago
641.1.15	Move setting these cursors out of the per-Screen loop totall... Move setting these cursors out of the per-Screen loop totally. Setting them up only requires the X connection, not any per-Scr info, so we can do 'em right up front.	Matthew Fuller	6 years ago
641.1.14	Macroize setting these defaults, and expand the comment a li... Macroize setting these defaults, and expand the comment a little to explain why/how.	Matthew Fuller	6 years ago
641.1.13	Move setting this sentinel value to alongside the other 3 ms... Move setting this sentinel value to alongside the other 3 msmts using the same sentinel for the same reason.	Matthew Fuller	6 years ago
641.1.12	Move these to their own block for symmetry. Move these to their own block for symmetry.	Matthew Fuller	6 years ago
641.1.11	Eliminate grabbing the server in this section of startup. Eliminate grabbing the server in this section of startup. It's a little unclear in looking if any of these bits really strongly need to be atomic. However, it's irrelevant, because grabbing doesn't nest; calling XGrabServer() multiple times does nothing, and the first XUngrabServer() call takes things to "normal". Shortly into this grabbed section, we loop over the windows on the screen, and SimulateMapRequest() them all. That HandleMapRequest()'s each, which AddWindow()'s them. And AddWindow() does a grab/ungrab pair. So the XUngrabServer() here actually never did anything, because the server was already ungrab'd on the first window we picked up. An argument could be made that AddWindow() should be more conditional to _not_ ungrab during the startup. The counterargument to that is that it _has_ been doing so, and no visible bad effects have been noticed (or been though important enough to investigate) in the last couple decades that it's been doing that, so we might as well accept it.	Matthew Fuller	6 years ago
641.1.10	Adjust a few more comments. Adjust a few more comments.	Matthew Fuller	6 years ago
641.1.9	Do a bunch more commenting and a few minor moves of the loop... Do a bunch more commenting and a few minor moves of the loop for setting up each screen. Many comments left in anticipation of future code movement.	Matthew Fuller	6 years ago
641.1.8	Add various narrative comments through the startup process (... Add various narrative comments through the startup process (outside of the per-screen loop), and sprinkle a few related x-refs in other files.	Matthew Fuller	6 years ago
641.1.7	Spell FD_CLOEXEC properly. Spell FD_CLOEXEC properly.	Matthew Fuller	6 years ago
641.1.6	Wrap a scope and comment around this "set up X connection" s... Wrap a scope and comment around this "set up X connection" stuff.	Matthew Fuller	6 years ago
641.1.5	Wrap a scope around setting up the InfoWindow too. Move the... Wrap a scope around setting up the InfoWindow too. Move the X attributes-related vars into it, and setup an independent copy of them over in the Size window stuff that needs to do similar things. The two should have nothing to do with each other, so having separate (though same named) vars is appropriate.	Matthew Fuller	6 years ago
641.1.4	Move setting up text sizeing bits for the SizeWindow into th... Move setting up text sizeing bits for the SizeWindow into the scope where we're doing the other SizeWindow stuff, and localize the vars used.	Matthew Fuller	6 years ago