-
Committer:
Matthew Fuller
-
Date:
2021-07-14 02:07:49 UTC
-
mfrom:
(685.1.38 dev)
-
Revision ID:
fullermd@over-yonder.net-20210714020749-dtnndjowiqmiy746
Do various non-functional cleanups.
Primarily this clears out all the remaining things clang-analyzer bitches
about (apart from stuff in lex generated code, which ain't my problem).
These basically consist of:
- Dead store warnings. Some of these are obviously eliminatable;
others are _correct_, but have instead been silenced because they're
intentionally dead stores for defensive reasons.
- Null pointer derefs. Some of these I'm pretty sure are impossible
due to whole-program invariants, others are probably impossible due
to how X works.
I'm fairly certain none of them indicate any real problems; if they did,
they'd be manifesting as segfaults, and we'd be hearing all about that.
So this is mostly just about clearing out the list as far as possible to
make it easier to find any meaningful ones that show up in the future.
Also tweak cmake config a bit to get useful compile_commands.json back
for dev use.