~cyphermox/ubuntu/wily/shim/upstream

Viewing all changes in revision 312.

  • Committer: Peter Jones
  • Author(s): Laszlo Ersek
  • Date: 2015-04-13 23:55:25 UTC
  • Revision ID: git-v1:6b2510522f92026dc17e1c5508bbfab935741012
Fix length of allocated buffer for boot option comparison.

The following commit:

  commit 4aac8a1179e160397d7ef8f1e3232cfb4f3373d6
  Author: Gary Ching-Pang Lin <glin@suse.com>
  Date:   Thu Mar 6 10:57:02 2014 +0800

    [fallback] Fix the data size for boot option comparison

corrected the data size used for comparison, but also reduced the
allocation so it doesn't include the trailing UTF16LE '\0\0' at the
end of the string, with the result that the trailer of the buffer
containing the string is overwritten, which OVMF detects as memory
corruption.

Increase the size of the storage buffer in a few places to correct
this problem.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Gary Ching-Pang Lin <glin@suse.com>

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: