~dantti/apper/master

Viewing all changes in revision 1161.

  • Committer: Albert Astals Cid
  • Author(s): Alexander Kernozhitsky
  • Date: 2019-03-21 22:11:08 UTC
  • Revision ID: git-v1:d486706f3e9f7eefa4d44cd5ace34eeaf7ba2ceb
Prevent crashing Apper on PackageModel::clearSelectedNotPresent()

Summary:
m_checkedPackages.erase() is called, but the iterator is not increased, therefore on the next iteration we use an invalid iterator

BUG: 405433
BUG: 401461
BUG: 402170

Test Plan: I just rebuilt Apper, ran it and installed the updates with it. The bug does not appear.

Reviewers: dantti, apol

Reviewed By: dantti

Differential Revision: https://phabricator.kde.org/D19951

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: