~didrocks/notify-osd/bootstrap

  • Committer: Tarmac
  • Author(s): Michael Terry
  • Date: 2012-11-26 19:37:13 UTC
  • mfrom: (456.1.1 no-border)
  • Revision ID: tarmac-20121126193713-qcfs6arzuhuepwmf
When running without a compositor, there is an ugly black border.

This branch fixes that by:
1) Adding an 'is_composited' argument to defaults_get_bubble_shadow_size and defaults_get_bubble_corner_radius.  If we're not composited, they return 0.0f.
2) Adding a 'GdkScreen **screen' argument to defaults_get_top_corner
3) Using these throughout to check composited state wherever these are used.

Additionally, I had to add some oddness in bubble.c for _refresh_background.  There is a bit of code that draws a (seemingly unnecessary) image in shadow-size-units even in the uncomposited case.  But it can't use 0 because that causes a crash to create a 0-sized image.  So I used 1 for that special case.  Seems like it would be cleaner to avoid that path in uncomposited mode, but I didn't feel confident enough to make that change.

Approved by Didier Roche, jenkins.
Filename Latest Rev Last Changed Committer Comment Size
..
data 24.1.4 15 years ago David Barth add D-BUS activation service Diff
egg 116.1.29 15 years ago David Barth big rename clutter -> egg to protect the innoncent Diff
examples 303 15 years ago Mirco Müller added examples form development-guidelines Diff
icons 18 15 years ago Mirco Müller added some test icons Diff
m4 3 15 years ago David Barth more autotool stuff Diff
manual-tests 454 12 years ago Mirco Müller Added manual test for Ryan's patch from the last c Diff
src 3 15 years ago David Barth more autotool stuff Diff
tests 13 15 years ago Mirco Müller added glib-based unit-tests Diff
.bzrignore 422.1.2 14 years ago Mirco Müller added C-example testing updating the icon of a not 5.4 KB Diff Download File
AUTHORS 432 13 years ago Mirco Müller updated list of contributors 807 bytes Diff Download File
File autogen.sh 184 15 years ago David Barth alsdorf is now officially known as 'notify-osd' 638 bytes Diff Download File
ChangeLog 9 15 years ago Mirco Müller bit of housekeeping 24 bytes Diff Download File
configure.in 456 12 years ago Mirco Müller bump version number to 0.9.34 for the new release 4 KB Diff Download File
Makefile.am 383 14 years ago Mirco Müller Merged Cody's valgrind-support branch after review 173 bytes Diff Download File
NEWS 439 12 years ago Mirco Müller updated C- and Python-examples, updated NEWS 1.1 KB Diff Download File
README 312.1.1 15 years ago Aurelien Gateau Added link to wiki page of the spec. 516 bytes Diff Download File
TODO 184 15 years ago David Barth alsdorf is now officially known as 'notify-osd' 97 bytes Diff Download File