~dooferlad/patchwork/niceties : changes

~dooferlad/patchwork/niceties » Changes from revision 278

From Revision 254 to 235

Rev	Summary	Authors	Date
254	forms: Fix MultipleBooleanField.to_python when the field val... forms: Fix MultipleBooleanField.to_python when the field value is missing If you write a test for, say, the bundle form of a patch list, you'd still have to specify the 'no change' value to other form (e.g. the multiple update one) fields using MultipleBooleanField or else it'd raise a ValueError when field.clean() is called as part of form._get_errors(). Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
253	models: use implied line continuations models: use implied line continuations Use the implied line continuations, and make the indentation more clear. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Jeremy Kerr	13 years ago
252	models: Project.is_editable to check whether a user has edit... models: Project.is_editable to check whether a user has edit rights This is to replace the couple of places where we duplicate this same check. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
251	views: Refactor generic_list() to make it less complicated views: Refactor generic_list() to make it less complicated When a form is submitted it now delegates to separate processing functions according to the action. Apart from being more readable it's now a lot easier to add extra forms for processing lists of patches. Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
250	admin: Streamline admin model registration admin: Streamline admin model registration Use autodiscover and the new way to hook AdminSite into the URLconf. AdminSite.root() will be removed in Django-1.3 as noted here: http://docs.djangoproject.com/en/dev/internals/deprecation/ Signed-off-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Dirk Wallenstein	13 years ago
249	settings: Remove hard-coded absolute paths settings: Remove hard-coded absolute paths This is so that you don't have to change a dozen variables when you deploy an instance somewhere other than on /srv/patchwork. Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
248	patchwork-update-commits: add missing `update` to command li... patchwork-update-commits: add missing `update` to command line Otherwise the following error is shown: Too many arguments specified Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Paul Menzel	13 years ago
247	Remove a bunch of unused variables Remove a bunch of unused variables Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
246	Use the 'in' operator instead of dict.has_key(), which has b... Use the 'in' operator instead of dict.has_key(), which has been deprecated Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
245	parser: Get rid of some code duplication in parsemail-batch.... parser: Get rid of some code duplication in parsemail-batch.sh Change parsemail-bash.sh to uses parsemail.sh (instead of parsemail.py), as the former sets the required environment variables that were being set in parsemail-batch.sh. Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
244	templates: remove redundant 'about' link from main nav templates: remove redundant 'about' link from main nav We have a link to the about page right below. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Jeremy Kerr	13 years ago
243	models: use User.post_save signal to create UserProfile obje... models: use User.post_save signal to create UserProfile objects Rather than relying on the registration app's callback mechanism to create the UserProfile object, use the post_save signal on auth.User. This means that the UserProfile will be created regardless of how the User was created. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Jeremy Kerr	13 years ago
242	Replace tab characters with spaces on .py files Replace tab characters with spaces on .py files Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
241	Remove unused imports Remove unused imports This is so that we can use static analysis tools like pyflakes to find undefined names (and other common mistakes we often make) without being swamped with unused imports warnings. Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
240	views: use id__in = get_patch_ids() to get the modified patc... views: use id__in = get_patch_ids() to get the modified patch set Currently, we generic_list processes patches in order of the patch_id:X parameter, which is arbitrarily decided by the browser. By using id__in, we get patches sorted by the default Patch model ordering. This means that the (arbitrary) order of get_patch_ids() doesn't affect the ordering of patches that we process, and bundles are created with a reasonable default patch order. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Jeremy Kerr	13 years ago
239	forms: Fix archiving/unarchiving of patches on patch lists forms: Fix archiving/unarchiving of patches on patch lists It was broken because MultipleBooleanField() was leaking string values instead of boolens as expected by MultiplePatchForm. Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
238	parser: Allow pull requests to include a diff parser: Allow pull requests to include a diff If a patch comes along with a pull request and a diff, add both to the Patch model. Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
237	Remove unused templates and some code for processing them Remove unused templates and some code for processing them These seem to be what was used in the past to archive/unarchive and delete patches. Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Guilherme Salgado	13 years ago
236	filters: quote param names and values when constructing quer... filters: quote param names and values when constructing querystrings Use urllib.quote to sanitise parameter names and values; prevents escaped ampersands in the input qs from appearing unescaped in the link output. Add a testcase for the unescaped qs fragments Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Jeremy Kerr	13 years ago
235	tests: Support execution of single tests tests: Support execution of single tests Django does not use suite() when executing single tests. Importing all tests directly into __init__.py has the same effect as the replaced version of suite(). Signed-off-by: Dirk Wallenstein <halsmit@t-online.de> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>	Dirk Wallenstein	13 years ago