1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
|
# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4; encoding:utf8 -*-
#
# Copyright 2014 Michael Terry <michael.terry@canonical.com>
#
# This file is part of duplicity.
#
# Duplicity is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by the
# Free Software Foundation; either version 2 of the License, or (at your
# option) any later version.
#
# Duplicity is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with duplicity; if not, write to the Free Software Foundation,
# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
from __future__ import print_function
from future import standard_library
standard_library.install_aliases()
import os
import sys
import subprocess
import pytest
import fnmatch
import os
if os.getenv(u'RUN_CODE_TESTS', None) == u'1':
# Make conditional so that we do not have to import in environments that
# do not run the tests (e.g. the build servers)
import pycodestyle
from . import _top_dir, DuplicityTestCase
from . import find_unadorned_strings
skipCodeTest = pytest.mark.skipif(not os.getenv(u'RUN_CODE_TESTS', None) == u'1',
reason=u'Must set environment var RUN_CODE_TESTS=1')
class CodeTest(DuplicityTestCase):
def run_checker(self, cmd, returncodes=[0]):
process = subprocess.Popen(cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
output = process.communicate()[0]
self.assertTrue(process.returncode in returncodes, output)
self.assertEqual(b"", output, output)
@skipCodeTest
def test_2to3(self):
# As we modernize the source code, we can remove more and more nofixes
self.run_checker([
u"2to3",
u"--nofix=next",
u"--nofix=types",
u"--nofix=unicode",
# The following fixes we don't want to remove, since they are false
# positives, things we don't care about, or real incompatibilities
# but which 2to3 can fix for us better automatically.
u"--nofix=callable",
u"--nofix=dict",
u"--nofix=future",
u"--nofix=imports",
u"--nofix=print",
u"--nofix=raw_input",
u"--nofix=urllib",
u"--nofix=xrange",
u"--nofix=map",
_top_dir])
@skipCodeTest
def test_pylint(self):
u"""Pylint test (requires pylint to be installed to pass)"""
self.run_checker([
u"pylint",
os.path.join(_top_dir, u'duplicity'),
os.path.join(_top_dir, u'bin/duplicity'),
os.path.join(_top_dir, u'bin/rdiffdir')])
@skipCodeTest
def test_pep8(self):
u"""Test that we conform to PEP-8 using pycodestyle."""
# Note that the settings, ignores etc for pycodestyle are set in tox.ini, not here
style = pycodestyle.StyleGuide(config_file=os.path.join(_top_dir, u'tox.ini'))
result = style.check_files([os.path.join(_top_dir, u'duplicity'),
os.path.join(_top_dir, u'bin/duplicity'),
os.path.join(_top_dir, u'bin/rdiffdir')])
self.assertEqual(result.total_errors, 0,
u"Found %s code style errors (and warnings)." % result.total_errors)
@skipCodeTest
def test_unadorned_string_literals(self):
u"""For predictable results in python/3 all string literals need to be marked as unicode, bytes or raw"""
ignored_files = [
# These are not source files we want to check
os.path.join(_top_dir, u'.tox', u'*'),
os.path.join(_top_dir, u'.eggs', u'*'),
os.path.join(_top_dir, u'docs', u'conf.py'),
# TODO Every file from here down needs to be fixed and the exclusion removed
]
# Find all the .py files in the duplicity tree
# We cannot use glob.glob recursive until we drop support for Python < 3.5
matches = []
def multi_filter(names, patterns):
u"""Generator function which yields the names that match one or more of the patterns."""
for name in names:
if any(fnmatch.fnmatch(name, pattern) for pattern in patterns):
yield name
for root, dirnames, filenames in os.walk(_top_dir):
for filename in fnmatch.filter(filenames, u'*.py'):
matches.append(os.path.join(root, filename))
excluded = multi_filter(matches, ignored_files) if ignored_files else []
matches = list(set(matches) - set(excluded))
matches.extend([
os.path.join(_top_dir, u"bin", u"duplicity"),
os.path.join(_top_dir, u"bin", u"rdiffdir")
])
do_assert = False
for python_source_file in matches:
# Check each of the relevant python sources for unadorned string literals
unadorned_string_list = find_unadorned_strings.check_file_for_unadorned(python_source_file)
if unadorned_string_list:
do_assert = True
print(u"Found {0:d} unadorned strings in {1:s}:".format(
len(unadorned_string_list), python_source_file),
file=sys.stderr)
for unadorned_string in unadorned_string_list:
print(unadorned_string[1:], file=sys.stderr)
self.assertEqual(do_assert, False, u"Found unadorned strings.")
if __name__ == u"__main__":
unittest.main()
|