- Committer: Tyler Hicks
- Date: 2017-06-09 15:39:12 UTC
- Revision ID: tyhicks@canonical.com-20170609153912-ltw0lodo5ps0aukl
Remove unreachable code when parsing mount opt name value pairs
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
ecryptfs_key_mod_gpg.c |
792 | 11 years ago | Tyler Hicks | * configure.ac: - Set AM_CPPFLAGS to always incl | 8.1 KB |
|
|
|
ecryptfs_key_mod_openssl.c |
887.1.1 | 7 years ago | Jelle van der Waa | Fix build with OpenSSL 1.1.x The rsa_st struct ha | 27.6 KB |
|
|
|
ecryptfs_key_mod_passphrase.c |
792 | 11 years ago | Tyler Hicks | * configure.ac: - Set AM_CPPFLAGS to always incl | 8.4 KB |
|
|
|
ecryptfs_key_mod_pkcs11_helper.c |
887.1.2 | 7 years ago | Jelle van der Waa | Fix build with OpenSSL 1.1.x The rsa_st struct ha | 41.7 KB |
|
|
|
ecryptfs_key_mod_tspi.c |
792 | 11 years ago | Tyler Hicks | * configure.ac: - Set AM_CPPFLAGS to always incl | 19.7 KB |
|
|
|
Makefile.am |
303 | 16 years ago | Dustin Kirkland | move the modprobe to a better place Move the modp | 2.2 KB |
|
|