- Committer: Tyler Hicks
- Date: 2017-06-09 15:39:12 UTC
- Revision ID: tyhicks@canonical.com-20170609153912-ltw0lodo5ps0aukl
Remove unreachable code when parsing mount opt name value pairs
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
Makefile.am |
406 | 15 years ago | Dustin Kirkland | * README, configure.ac, debian/control, debian/r | 553 bytes |
|
|
|
pam_ecryptfs.c |
855.1.2 | 10 years ago | Tyler Hicks | * src/utils/mount.ecryptfs_private.c: Add an optio | 15.5 KB |
|
|