- Committer: Tyler Hicks
- Date: 2017-06-09 15:39:12 UTC
- Revision ID: tyhicks@canonical.com-20170609153912-ltw0lodo5ps0aukl
Remove unreachable code when parsing mount opt name value pairs
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
kernel
|
625 | 13 years ago | Tyler Hicks | * tests/lib/etl_funcs.sh: - created eCryptfs tes |
|
||
|
lib
|
625 | 13 years ago | Tyler Hicks | * tests/lib/etl_funcs.sh: - created eCryptfs tes |
|
||
|
userspace
|
625 | 13 years ago | Tyler Hicks | * tests/lib/etl_funcs.sh: - created eCryptfs tes |
|
||
Makefile.am |
652 | 13 years ago | Tyler Hicks | Fix up multiple test suite problems when using mak | 74 bytes |
|
|
new.sh |
625 | 13 years ago | Tyler Hicks | * tests/lib/etl_funcs.sh: - created eCryptfs tes | 955 bytes |
|
|
|
README |
822 | 11 years ago | Colin King | * tests/README - fix spelling mistake: similiar | 4.7 KB |
|
|
|
run_tests.sh |
681 | 13 years ago | Tyler Hicks | * tests/run_tests.sh: - Accept a comma-separated | 8 KB |
|
|