- Committer: Tarmac
- Date: 2014-04-22 19:06:44 UTC
- mfrom: (504.1.2 026-3)
- Revision ID: tarmac-20140422190644-nep5wth304pk36p8
Fix migration wrt invalid constraints.
The migration 026 for rewriting contraints to be space-separated worked for
staging. When run on production it had errors due to some of the bundles on
production being older than the more restrictive bundle proofing
requirements. Those bundles were in essence grandfathered in and never
subject to the stricter rules. At least one bundle had an obsolete 'cpu'
constraint and that caused the migration to fail since it was not checking for
the thrown ValueError in this situation.
The migration now checks for ValueError and will remove the affected bundle
from the target database and proceed.
The functions are now noted to throw ValueError.
Test was added for this situation and logging checked.
https://codereview.appspot.com/90420043/
R=jcsackett.
Approved by Juju Gui Bot.
The migration 026 for rewriting contraints to be space-separated worked for
staging. When run on production it had errors due to some of the bundles on
production being older than the more restrictive bundle proofing
requirements. Those bundles were in essence grandfathered in and never
subject to the stricter rules. At least one bundle had an obsolete 'cpu'
constraint and that caused the migration to fail since it was not checking for
the thrown ValueError in this situation.
The migration now checks for ValueError and will remove the affected bundle
from the target database and proceed.
The functions are now noted to throw ValueError.
Test was added for this situation and logging checked.
https://codereview.appspot.com/90420043/
R=jcsackett.
Approved by Juju Gui Bot.
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
charmworld
|
1 | 13 years ago | kapil.foss at gmail | charmworld pyramid starter |
|
||
|
docs
|
33 | 13 years ago | kapil.foss at gmail | add install doc |
|
||
|
scripts
|
21 | 13 years ago | Kapil Thangavelu | add ctl scripts |
|
||
.bzrignore |
458.1.3 | 11 years ago | j.c.sackett | Bzr should ignore our conventional lp credentials | 430 bytes |
|
|
|
.lbox |
419.1.2 | 11 years ago | Brad Crittenden | lbox defaults to -cr and sets project to charmworl | 31 bytes |
|
|
.lbox.check |
491.1.2 | 10 years ago | Brad Crittenden | Move lint before test in lbox.check | 66 bytes |
|
|
|
CHANGES.txt |
67.1.10 | 12 years ago | Kapil Thangavelu | put back accidentally yanked changes | 28 bytes |
|
|
|
default.ini |
474.1.6 | 10 years ago | j.c.sackett | Changes to address commentar in review. | 2.9 KB |
|
|
|
distribute_setup.py |
71.1.2 | 12 years ago | Rick Harding | Add missing files | 15.3 KB |
|
|
|
LICENSE.txt |
61 | 12 years ago | kapil.foss at gmail | add license | 33.7 KB |
|
|
|
Makefile |
482.1.1 | 10 years ago | Brad Crittenden | Turn on lint for migrations and fix | 5.1 KB |
|
|
|
MANIFEST.in |
1 | 13 years ago | kapil.foss at gmail | charmworld pyramid starter | 133 bytes |
|
|
|
README.txt |
7 | 13 years ago | kapil.foss at gmail | work in progress on multi namespace support | 252 bytes |
|
|
|
requirements.txt |
487.2.1 | 10 years ago | Brad Crittenden | Check charm constraints when doing proof. Lots of | 1.3 KB |
|
|
|
setup.cfg |
304.4.26 | 11 years ago | Aaron Bentley | Move logging filters to nose config. | 569 bytes |
|
|
|
setup.py |
461.3.2 | 11 years ago | Benji York | checkpoint | 1.4 KB |
|
|
|
test-setup.ini |
474.1.6 | 10 years ago | j.c.sackett | Changes to address commentar in review. | 668 bytes |
|
|