-
Committer:
Tarmac
-
Author(s):
John Arbash Meinel
-
Date:
2013-08-28 12:36:27 UTC
-
mfrom:
(1705.4.4 bad-formatting-1216285)
-
Revision ID:
tarmac-20130828123627-r38fc3kmubd7nucc
[r=jameinel],[bug=1216285] environs/tools: print out the correct version
Bug #1216285 is because we were miss-formatting a line about what
version we were filtering. It turns out that while we were printing out
an int as "%s" we were also not priting out what the filter would
actually match. (If you pass a version in that field, we match the exact
version, not just the major version.)
In the process, I realized we don't have much infrastructure for testing
what log messages we are writing, so I added a LogMatches checker. I
think it is something that actually fits better inside the loggo
package, but I wanted to give it some real experience before I tried to
get it into upstream.
https://codereview.appspot.com/12744051/