~frankban/juju-quickstart/interactive-errors : changes

~frankban/juju-quickstart/interactive-errors » Changes from revision 102

From Revision 83 to 64

Rev	Summary	Authors	Tags	Date
83	Update README for OS X installation. Update README for OS X installation. R=jeff.pihach CC= https://codereview.appspot.com/109050044	Brad Crittenden		10 years ago
82	Avoid proposing LXC envs as an option on MacOS. Avoid proposing LXC envs as an option on MacOS. R=bac CC= https://codereview.appspot.com/105250043	Francesco Banconi		10 years ago
81	Fail early if brew is not installed. Fail early if brew is not installed. Did some refactoring to list required files for each supported platform. If required files are not found, fail early with an appropriate parser error message. R=frankban CC= https://codereview.appspot.com/108930045	Brad Crittenden		10 years ago
80	Release 1.3.5 Release 1.3.5 Required due to the incorrect naming of 1.3.4.b1 previously. R= CC= https://codereview.appspot.com/108890044	Brad Crittenden		10 years ago
79	Bump version to 1.3.4 for release. Bump version to 1.3.4 for release. R= CC= https://codereview.appspot.com/109830043	Brad Crittenden	1.3.5	10 years ago
78	Update HACKING doc. Update HACKING doc. Reference the two different packaging recipes for trusty and beyond and for the pre-trusty series. The packaging branches are now two separate series: lp:juju-quickstart/packaging and lp:juju-quickstart/packaging-pre-trusty. Referencing them in the recipes is cleaner than using bare branch names. Also add a QA step for environments.yaml generation. R=frankban CC= https://codereview.appspot.com/103310043	Brad Crittenden		10 years ago
77	Add QA procedures to HACKING.rst Add QA procedures to HACKING.rst New QA steps added. Also updated PPA build procedure given we have bifurcated the pre-trusty and trusty-and-beyond steps. R= CC= https://codereview.appspot.com/103290043	Brad Crittenden	1.3.4	10 years ago
76	Mv requirement for websocket to requirements.pip Mv requirement for websocket to requirements.pip If websocket is in test-requirements.pip then PIP will not install it properly. Putting it there was an attempt to get the Ubuntu packages to build for trusty and prior but it is not a workable strategy. Bump version to 1.3.4.b1 R= CC= https://codereview.appspot.com/104000043	Brad Crittenden		10 years ago
75	Error if local env requested but not supported. Error if local env requested but not supported. If '-e some-local-environment' is used on a host that does not support LXC, then bootstrap will be called and an obscure 'apt-config' error is thrown. So, let's not do that. Instead, detect the error early and return an argparse error that makes sense. R= CC= https://codereview.appspot.com/104940045	Brad Crittenden		10 years ago
74	Move websocket-client to test-requirements.pip. Move websocket-client to test-requirements.pip. R= CC= https://codereview.appspot.com/105820045	Francesco Banconi		10 years ago
73	Bump version up for release 1.3.3. Bump version up for release 1.3.3. R= CC= https://codereview.appspot.com/102190043	Francesco Banconi		10 years ago
72	Make juju-quickstart websockets use TLSv1. Make juju-quickstart websockets use TLSv1. On OS X by default websockets try to use SSLv2 first. The juju-gui server rejects the attempt and they do not renogiate a shared protocol, resulting in a handshake failure. The least invasive and most secure solution is to create a websocket that is forced to use TLSv1. R=redir CC= https://codereview.appspot.com/105810043	Brad Crittenden		10 years ago
71	Reorganize platform settings. Reorganize platform settings. The first cut of the platform work was a bit unclean with respect to the dividing lines between the quickstart app code and the parts that can be re-used as a library. This branch moves things around to re-attain that separation. R=redir CC= https://codereview.appspot.com/101980050	Brad Crittenden		10 years ago
70	Include installation steps for OS X. Include installation steps for OS X. A slight re-factoring was done to move platform-specific steps from app.py to platform_support.py. The redefinition of JUJU_CMD is a known problem and a refactoring branch will be forthcoming. R=frankban CC= https://codereview.appspot.com/102870043	Brad Crittenden		10 years ago
69	Fix quickstart test failing on osx. Fix quickstart test failing on osx. R= CC= https://codereview.appspot.com/101970044	Francesco Banconi		10 years ago
68	Add a function for determing OS flavor. Add a function for determing OS flavor. Determines OS and then for the case of Linuxes, determines whether the system uses apt-get or RPM. R=frankban CC= https://codereview.appspot.com/99410054	Brad Crittenden		10 years ago
67	Check unicode support. Check unicode support. Ensure utf-8 is supported before starting the Urwid interactive session. This way we hope to avoid bad crashes when the user has locale configuration problems. Tests: `make check`. QA: If you have juju-quickstart installed, you should be able to make it crash by overriding all the language env vars, like the following: `LC_ALL=C juju-quickstart -i` You should see a UnicodeEncodeError: 'ascii' codec can't encode character u'\u2582' in position 0: ordinal not in range(128) With this branch, the following should instead work as usual: `LC_ALL=C .venv/bin/python juju-quickstart -i`. I am not sure how to make Urwid fail so that we can QA the system exit in the code, but at least that code path is tested. R=rharding CC= https://codereview.appspot.com/90740043	Francesco Banconi		10 years ago
66	Support trusty environments. Support trusty environments. Add the ability to deploy the trusty charm. Introduced the concept of multiple supported series for the Juju GUI charm. Split the app.deploy_gui function in two separate function: - check_environment inspects the environment and returns the data required to deploy the GUI; - deploy_gui's only responsibility is to return when the GUI service is deployed/exposed and the unit created. Include the default-series field in the auto-generated local environment. This is the environment that quickstart offers to automatically create when no other environments are found. Also propose "trusty" as the default series when manually creating new environments. Bump version up: while this branch incidentally fixes bug 1306537 [1], the ability to deploy the GUI on trusty can be considered a new feature. My apologies for the long diff. Tests: `make check`. QA: Use quickstart like the following: `.venv/bin/python juju-quickstart [-i]`. You should be able to deploy the trusty GUI charm. If you are on trusty, the trusty charm should be deployed when the default-series field is missing. This must be tested also using the local provider, in which case Juju is currently not able to deploy precise charms when the bootstrap node is trusty (bug 1306537). In general quickstart should deploy the charm series corresponding to the bootstrap node series: so on trusty environments the trusty charm should be installed, on precise environments the precise one. This way, at least when the bootstrap node series is precise or trusty, quickstart is able to add the GUI unit to machine 0. You can test it using, e.g. an ec2 environment. This is true also when providing a custom charm URL, e.g.: `.venv/bin/python juju-quickstart --gui-charm-url cs:~juju-gui/trusty/juju-gui-1` In all the other cases, quickstart uses the trusty charm. You can test this by using quickstart with an ec2 environment having "default-series: saucy": a trusty GUI should be deployed on machine 1. Two final checks: - try to create a new environment with quickstart: the default-series field should be pre-filled with "trusty"; - move temporarily your environments.yaml somewhere else, and let quickstart auto-generate a local environment for you: the deployment process should succeed and the environment should include the "trusty" default series. Thanks a lot for all of this, and sorry for the long QA: this is going to be released in trusty, so your efforts are really appreciated! [1] https://bugs.launchpad.net/juju-core/+bug/1306537 R= CC= https://codereview.appspot.com/90570044	Francesco Banconi		10 years ago
65	Make control-bucket optional. Make control-bucket optional. The existing function get_admin_secret is made generic and the name is changed to get_value_from_jenv. It now takes a keyname to be fetched from the generated file. For both ec2 and openstack the control-bucket field has been made optional with respect to the environments.yaml file. QA: 1) Create an ec2 environment with no control-bucket. 2) Bootstrap that environment. Ensure a control-bucket is in the .jenv file. 3) Run quickstart and see that it uses the existing environment and does not raise an error. R=frankban CC= https://codereview.appspot.com/90060043	Brad Crittenden		10 years ago
64	Add support for the Joyent provider. Add support for the Joyent provider. Tests: `make check`. QA: QA is not straightforward for this branch, due to the fact this needs to be tested on a not yet released juju-core. Sorry about that. 1) Check out the 1.18 juju-core branch (lp:juju-core/1.18), and compile it. 2) Edit the quickstart/settings.py file included in this branch: set `JUJU_CMD` to point to the juju 1.18 path. 3) Sign up for a Joyent account from http://www.joyent.com/. 4) Run `.venv/bin/python juju-quickstart -i` and create a new joyent environment: DO NOT bootstrap it from quickstart, just create it and exit (^X). 5) Use juju 1.18 to bootstrap the joyent account, e.g. `juju bootstrap -e joyent --upload-tools`. This is required because quickstart does not support uploading tools. 6) After a minute, and while the environment is bootstrapping, open another terminal and re-run quickstart, select the joyent account you created and hit "use" (or just invoke quickstart with `-e joyent`). 7) Ensure everything proceeds as expected, and wait until the quickstart opens the GUI. Done, destroy the environment, thank you! R=bac CC= https://codereview.appspot.com/83880044	Francesco Banconi		10 years ago

Older »