-
Committer:
Matthew Fuller
-
Date:
2019-03-24 20:47:35 UTC
-
Revision ID:
fullermd@over-yonder.net-20190324204735-6fhk08s8invbc3gz
Silence output from patch(1) in git-apply test.
The test suite stubs in stdout/err wrappers for the python code, but
doesn't mess with the underlying file descriptors, so spawned off
processes still get the terminal. cmd_git_apply._apply_patch() uses
subprocess to spawn off the system patch(1) to do the application, and
patch talks a lot about what it's doing. While patch has a -s arg to
quiet it down, we probably want it speaking a lot in normal use so the
user can see what's going on, so just switch stdout to /dev/null
around the run_bzr call in the test instead.
An argument could be made that the test suite as a whole should be
better about moving the fd's so subprocesses can't hit the terminal
directly, but for the moment, this seems to be the only test where it
matters.