2034
|
|
|
William Reade |
10 years ago
|
|
|
2033
|
|
|
William Reade |
10 years ago
|
|
|
2032
|
|
[r=jameinel] rpc/apiserver: logging improvements
This is a bunch of tweaks to the RPC logging statements to make them nicer to use.
1) Add wall-clock time to responses. This lets you see quickly how long a given RPC took to process.
2) Add a unique identifier per-connection. The code was sort of written around remoteAddr (it collected it, at least), but it turns out that isn't actually enough. Roger mentioned using the address of an object, but those can be reused. Using a unique counter allows us to both guarantee it is unique for the lifetime of the process, and makes the numbers significantly smaller. I also went with Hex form to save a couple bytes, but I'm not wedded to it. I could be convinced that %d would be better than %x. I did go with [%x] to ensure that you can search for a stream without hitting prefix/suffix/etc matches.
3) Once the remote side has logged in, the log messages include the Tag of that entity. I find that to be quite useful (especially to clarify unit agents from machine agents, etc). The Facade they are using is already in the requests (as Type).
This is based on my earlier patch that fixes the API endpoint bugs. I could pull it out if that patch gets rejected, as it isn't an actual dependency, just code committed after the other one. I don't expect it will be an actual problem, though.
https://codereview.appspot.com/18990045/
|
John Arbash Meinel |
10 years ago
|
|
|
2031
|
|
|
John Arbash Meinel |
10 years ago
|
|
|
2030
|
|
|
Andrew Wilkins |
10 years ago
|
|
|
2029
|
|
|
Andrew Wilkins |
10 years ago
|
|
|
2028
|
|
|
Andrew Wilkins |
10 years ago
|
|
|
2027
|
|
|
Ian Booth |
10 years ago
|
|
|
2026
|
|
|
Ian Booth |
10 years ago
|
|
|
2025
|
|
|
Ian Booth |
10 years ago
|
|
|
2024
|
|
|
Ian Booth |
10 years ago
|
|
|
2023
|
|
|
Tim Penhey |
10 years ago
|
|
|
2022
|
|
|
Nate Finch |
10 years ago
|
|
|
2021
|
|
|
Tim Penhey |
10 years ago
|
|
|
2020
|
|
|
Ian Booth |
10 years ago
|
|
|
2019
|
|
|
Andrew Wilkins |
10 years ago
|
|
|
2018
|
|
|
Andrew Wilkins |
10 years ago
|
|
|
2017
|
|
|
Tim Penhey |
10 years ago
|
|
|
2016
|
|
|
Nick Veitch |
10 years ago
|
|
|
2015
|
|
|
Andrew Wilkins |
10 years ago
|
|
|