14131
|
|
|
Source Maintenance |
|
7 years ago
|
|
|
14130
|
|
|
Source Maintenance |
|
7 years ago
|
|
|
14129
|
|
|
Amos Jeffries |
|
7 years ago
|
|
|
14128
|
|
|
Amos Jeffries |
SQUID_3_5_23 |
7 years ago
|
|
|
14127
|
|
Do not share private responses with collapsed client(s).
This excessive sharing problem with collapsed forwarding code has several layers. In most cases, the core CF code does not share uncachable or private response with collapsed clients because of the refreshCheckHTTP() check. However, some responses might not be subject to that (or equivalent) check. More importantly, collapsed revalidation code does not check its responses at all and, hence, easily shares private responses.
This short-term fix incorrectly assumes that an entry may become private (KEY_PRIVATE) only when it cannot be shared among multiple clients (e.g., because of a Cache-Control:private response header). However, there are a few other cases when an entry becomes private. One of them is a DISK_NO_SPACE_LEFT error inside storeSwapOutFileClosed() where StoreEntry::releaseRequest() sets KEY_PRIVATE for a sharable entry [that may still be perfectly preserved in the memory cache]. Consequently, the short-term fix reduces CF effectiveness. The extent of this reduction is probably environment-dependent.
Also: do not re-use SET_COOKIE headers for collapsed revalidation slaves, i.e., adhere to the same requirement as for regular response HITs.
|
Eduard Bagdasaryan |
|
7 years ago
|
|
|
14126
|
|
|
Garri Djavadyan |
|
7 years ago
|
|
|
14125
|
|
|
Garri Djavadyan |
|
7 years ago
|
|
|
14124
|
|
|
Amos Jeffries |
|
7 years ago
|
|
|
14123
|
|
|
Garri Djavadyan |
|
7 years ago
|
|
|
14122
|
|
|
Source Maintenance |
|
7 years ago
|
|
|
14121
|
|
|
Michael Buchau |
|
7 years ago
|
|
|
14120
|
|
|
Egervary Gergely |
|
7 years ago
|
|
|
14119
|
|
|
Christos Tsantilas |
|
7 years ago
|
|
|
14118
|
|
|
Garri Djavadyan |
|
7 years ago
|
|
|
14117
|
|
|
Stephen Baynes |
|
7 years ago
|
|
|
14116
|
|
|
Garri Djavadyan |
|
7 years ago
|
|
|
14115
|
|
|
Christos Tsantilas |
|
7 years ago
|
|
|
14114
|
|
|
Amos Jeffries |
|
7 years ago
|
|
|
14113
|
|
|
Amos Jeffries |
|
7 years ago
|
|
|
14112
|
|
|
Alex Rousskov |
|
7 years ago
|
|
|