~gary/charms/precise/juju-gui/npm-cache-only-for-builds : changes

~gary/charms/precise/juju-gui/npm-cache-only-for-builds » Changes from revision 70

From Revision 70 to 51

Rev	Summary	Authors	Date
70	npm cache should only be used when a branch is built. npm cache should only be used when a branch is built.	Gary Poster	10 years ago
69	Expose 'use-analytics' via the charm. Expose 'use-analytics' via the charm. R=teknico, matthew.scott CC= https://codereview.appspot.com/10395043	Brad Crittenden	10 years ago
68	Charm test improvements. Charm test improvements. This branch includes some improvements to the charm testing infrastructure: Strengthened the Juju implementation check by introducing a new juju_version helper function. Do not require the branch to be named "juju-gui" anymore: the charm can be tested and deployed from an arbitrary branch. Updated documentation. Added the .lbox.check file: now, before proposing/submitting at least the lint check and the unit tests must pass. R=teknico, j.c.sackett CC= https://codereview.appspot.com/9714047	Francesco Banconi	10 years ago
67	Add AGPL license and headers. Add AGPL license and headers. Add headers pointing to the AGPL license to almost all files, and add the license text itself. Sorry for the size, it's just comments, no behavior change. R=matthew.scott, frankban CC= https://codereview.appspot.com/9836045	Nicola Larosa	10 years ago
66	Fix the charmworld URL default value. Fix the charmworld URL default value. Missing trailing slash. R= CC= https://codereview.appspot.com/10192043	Francesco Banconi	10 years ago
65	Replace jitsu test with juju-test. Replace jitsu test with juju-test. This branch makes juju-test the default test runner for both the unit tests and the charm functional tests. The charm test suite now supports both pyJuju and juju-core. The tests dependencies are now installed in a virtualenv that is automatically created and updated by the first test executable (00-setup). This way we don't require the user to install all the packages, and, moreover, we make the tests ready to be run in the charm testing infrastructure. When the charm is deployed during tests, a temporary repository is created where the charm is copied and then deployed. This way we achieve two important goals: - the developer is not forced to manually set up a local Juju repository where to branch the Juju GUI; - the charm can be deployed even if it contains a virtualenv, i.e. a directory with absolute symlinks (that's because the .venv dir is not copied in the temp repo). The tests/helpers.py and tests/deploy.py files will be eventually replaced by similar tools provided by the juju testing harness. Updated the documentation where required. Fixed unit tests exit code. Common commands (test/lint/clean etc.) can now be easily run using make. Nice to have, not included in this branch: - collect deployment test logs; - reintroduce a way to test the charm specifying a different juju-gui-source; - do not require the branch to be named "juju-gui". PS: sorry for the diff, well over 1k loc :-/ R= CC= https://codereview.appspot.com/9874050	Francesco Banconi	10 years ago
64	Fix backend unit tests. Fix backend unit tests. Make the backend unit tests not expect any extra repositories. R=frankban, bac CC= https://codereview.appspot.com/10020044	Nicola Larosa	10 years ago
63	[TRIVIAL] Add .lbox for specifying the target [TRIVIAL] Add .lbox for specifying the target R= CC= https://codereview.appspot.com/10009043	Brad Crittenden	10 years ago
62	Fix the discrepancy between dev and rel branches. Fix the discrepancy between dev and rel branches. Changes that should've been submitted to the development branch of the gui (lp:~juju-gui/charms/precise/juju-gui/trunk) were instead merged into the release branch (lp:charms/juju-gui). This branch merges those changes back into devel for on-going work. The premature release will remain in place. R=teknico CC= https://codereview.appspot.com/9975046	Brad Crittenden	10 years ago
61	Take the juju API address from the environment Take the juju API address from the environment The charm now tries to retrieve the juju API address from the hook context before parsing the machiner agent file. This way we take advantage of a change in juju-core currently in review, which introduces the corresponding functionality. R= CC= https://codereview.appspot.com/9810044	Francesco Banconi	10 years ago
60	Describe how to use juju-core in README.md . Describe how to use juju-core in README.md . Update README.md with instructions specific to juju-core, with regard to the alternative for the update-to pyjuju command. R=bac CC= https://codereview.appspot.com/9676045	Nicola Larosa	10 years ago
59	Allow "juju-origin: lp:juju" in env. Allow "juju-origin: lp:juju" in env. Fix charm to work when juju-origin is set to lp:juju in the environment. QAed with both lp:juju and ppa as values. R=jeff.pihach, bac CC= https://codereview.appspot.com/9646043	Nicola Larosa	10 years ago
58	Support juju-gui-source=branch:revno Support juju-gui-source=branch:revno Added support for creating and deploying a release from a specific branch revision. R=bac, jeff.pihach CC= https://codereview.appspot.com/9464043	Francesco Banconi	10 years ago
57	More charm code cleanup. More charm code cleanup. Most of these changes were split from the former branch that added backend unit tests, it was getting too big and unreadable. No behavior changes, only formatting and two occasions of different expressions of the same meaning. R=frankban, gary.poster CC= https://codereview.appspot.com/9125046	Nicola Larosa	10 years ago
56	Fix import errors in stop hook. Fix import errors in stop hook. This branch includes three trivial fixes: - stop hook not working; - using https://manage.jujucharms.com as charmworld URL by default; - no need to provide credentials in sandbox mode. R=teknico, gary.poster CC= https://codereview.appspot.com/9125043	Francesco Banconi	10 years ago
55	Add more unit tests to the charm backend. Add more unit tests to the charm backend. More unit tests for backend properties, commands and methods. In order to do that, it mangles the charm code pretty heavily: - it adds module prefixes to all functions imported by backend.py in order to make them monkeypatchable in tests; - it renames all sub-backends to mixins, for clarity. Arguably, "backend.mixins lists all active mixins" is clearer than "backend.backends lists all active sub-backends, some of which are actual backends and some others are mixins"; - it simplifies the code in a number of places; - it removes unused or scarcely used code in backend.py, for simplicity; - it rephrases some docstrings in more specific terms, for readability; - it removes the overrideable testing framework in backend.py. It imposes a runtime and complexity cost for doing what is already done in other tests by monkeypatching; Further style changes have been moved to a subsequent branch. It also fixes two import errors. WARNING: this branch did successfully deploy a stable juju-gui release. Deploy tests did not run successfully though, and they seem to be broken in trunk too, right now. R=bcsaller, frankban CC= https://codereview.appspot.com/9121043	Nicola Larosa	10 years ago
54	Reinstate test symbolic links. Reinstate test symbolic links. Actually reinstate test symbolic links that were mistakenly replaced with copies of the linked files. Trivial, self-reviewed. R= CC= https://codereview.appspot.com/9106044	Nicola Larosa	10 years ago
53	add missing parameter add missing parameter	Benji York	10 years ago
52	fix accedentally removed symlinks fix accedentally removed symlinks	Benji York	10 years ago
51	Use the npm cache to speed installs from a branch Use the npm cache to speed installs from a branch Creating the cache is handled by the GUI Makefile	Benji York	10 years ago

Older »