- Committer: Tarmac
- Date: 2013-09-04 16:17:58 UTC
- mfrom: (100.2.2 httpclient-ssl)
- Revision ID: tarmac-20130904161758-ms9sbkj862taq2mt
[r=jameinel] http.Client: support InsecureSkipVerify
This adds a new API http.NewNonSSValidating which ends up passing
InsecureSkipVerify: true all the way down the http stack. Because we
were using the global stdlib net/http.DefaultClient to enable
connection sharing, etc, we continue to cache the http.Client object.
I only create the object once we actually need it, and we only use it
for requests that also want to be "insecure".
I'm open to suggestions if we want to name the API differently. We
could also do it as a flag to New() but that is an API break (meaning
juju-core stops building until we patch juju-core). So I felt this was
a reasonable method.
This is step 2 in my work to support ssl-hostname-verify:false for the
Openstack provider. (bug #1202163)
https://codereview.appspot.com/13520043/
This adds a new API http.NewNonSSValidating which ends up passing
InsecureSkipVerify: true all the way down the http stack. Because we
were using the global stdlib net/http.DefaultClient to enable
connection sharing, etc, we continue to cache the http.Client object.
I only create the object once we actually need it, and we only use it
for requests that also want to be "insecure".
I'm open to suggestions if we want to name the API differently. We
could also do it as a flag to New() but that is an API break (meaning
juju-core stops building until we patch juju-core). So I felt this was
a reasonable method.
This is step 2 in my work to support ssl-hostname-verify:false for the
Openstack provider. (bug #1202163)
https://codereview.appspot.com/13520043/
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
export_test.go |
66.1.3 | 11 years ago | Ian Booth | Add tests for numeric and string ids | 68 bytes |
|
|
|
json.go |
95.3.2 | 10 years ago | Ian Booth | Improve json marshalling | 7.1 KB |
|
|
|
json_test.go |
95.3.1 | 10 years ago | Ian Booth | Make security group related ids and floating ip re | 1.5 KB |
|
|
|
live_test.go |
71.2.1 | 11 years ago | Ian Booth | Add bug numbers to todo's and remove some no longe | 14.3 KB |
|
|
|
local_test.go |
95.1.1 | 10 years ago | Ian Booth | Ensure auth response struct can accept a null tena | 7.3 KB |
|
|
|
nova.go |
99.1.3 | 10 years ago | Michael Nelson | Reword status comment and reuse var in test. | 22.7 KB |
|
|
|
nova_test.go |
95.3.1 | 10 years ago | Ian Booth | Make security group related ids and floating ip re | 1.8 KB |
|
|