~go-bot/goose/trunk

  • Committer: Tarmac
  • Author(s): John Arbash Meinel
  • Date: 2013-09-04 16:17:58 UTC
  • mfrom: (100.2.2 httpclient-ssl)
  • Revision ID: tarmac-20130904161758-ms9sbkj862taq2mt
[r=jameinel] http.Client: support InsecureSkipVerify

This adds a new API http.NewNonSSValidating which ends up passing
InsecureSkipVerify: true all the way down the http stack. Because we
were using the global stdlib net/http.DefaultClient to enable
connection sharing, etc, we continue to cache the http.Client object.
I only create the object once we actually need it, and we only use it
for requests that also want to be "insecure".

I'm open to suggestions if we want to name the API differently. We
could also do it as a flag to New() but that is an API break (meaning
juju-core stops building until we patch juju-core). So I felt this was
a reasonable method.

This is step 2 in my work to support ssl-hostname-verify:false for the
Openstack provider. (bug #1202163)

https://codereview.appspot.com/13520043/
Filename Latest Rev Last Changed Committer Comment Size
..
live_test.go 72.2.5 11 years ago Ian Booth Remove mutex implementation and timeout the auth r 6.5 KB Diff Download File
local_test.go 84.3.4 11 years ago Danilo Šegan Extend OpenStack test service to support keypair a 1.5 KB Diff Download File
swift.go 71.2.1 11 years ago Ian Booth Add bug numbers to todo's and remove some no longe 6.2 KB Diff Download File
swift_test.go 20.2.10 11 years ago Ian Booth Code review changes, do not require proper credent 437 bytes Diff Download File