-
Committer:
Kapil Thangavelu
-
Author(s):
Jeroen T. Vermeulen
-
Date:
2013-03-01 08:51:45 UTC
-
mfrom:
(617.1.1 makefile-fixups)
-
Revision ID:
kapil.foss@gmail.com-20130301085145-tejkmbjhnmx2ntr4
Makefile improvements and fixes.
Whenever I tried to run "make check" or "make review" in a juju branch, I would get output like:
bzr: ERROR: Not a branch: "/".
bzr: ERROR: Not a branch: "/".
bzr: ERROR: Not a branch: "/".
bzr: ERROR: Not a branch: "/".
make: *** [check] Error 1
The errors seem to happen (and I'll admit I don't know how or why) because
there are several lines in the Makefile each defining $(modified) as a shell
command involving bzr. I get the same result on a cloud machine as on my development system.
Giving each of those variables a separate name fixed the errors.
There were also other problems: the linters weren't actually being run, there
was no helpful indication of pep8 and/or pyflakes being missing, newly added
files weren't being checked, greps for ".py" suffixes sometimes neglectedto
escape the dot (so it stood for "any character followed by py"). I fixed all of those.
Finally there were some cosmetic nuisances. Spacing of the command lines was
irregular, and some use of Perl-style regexes in grep became unnecessary.
One of the checks in the "review" target was commented out. I don't know why,
so I left that as-is.