134
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
133
|
|
|
Brian Waldon |
13 years ago
|
|
|
132
|
|
|
Brian Waldon |
13 years ago
|
|
|
131
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
130
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
129
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
128
|
|
|
Brian Waldon |
13 years ago
|
|
|
127
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
126
|
|
|
Brian Waldon |
13 years ago
|
|
|
125
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
124
|
|
|
Brian Waldon |
13 years ago
|
|
|
123
|
|
|
Joseph Suh |
13 years ago
|
|
|
122
|
|
|
Brian Waldon |
13 years ago
|
|
|
121
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
120
|
|
|
Dan Prince |
13 years ago
|
|
|
119
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
118
|
|
|
jaypipes at gmail |
13 years ago
|
|
|
117
|
|
Fixing tests. Sorry for late response.
Rick Harris wrote on 2011-04-12 Really nice job, Eldar.
> 46 + image_swift = StringIO.StringIO("nevergonnamakeit") > 47 + options = SWIFT_OPTIONS.copy() > 48 + del options['swift_store_user'] > 49 + self.assertRaises(BackendException, > 50 + SwiftBackend.add, > 51 + 2, image_swift, options)
Might be better to DRY up the code some by adding a helper-method, like:
def assertOptionRequiredForSwift(self, key): image_swift = StringIO.StringIO("nevergonnamakeit") options = SWIFT_OPTIONS.copy() del options[key] self.assertRaises(BackendException, SwiftBackend.add, 2, image_swift, options)
Marking as Needs Fixing, but if you don't like the idea, I'd be willing to set this as Approved (since the suggestion is so minor :-)
|
Eldar Nugaev |
13 years ago
|
|
|
116
|
|
|
Thierry Carrez |
13 years ago
|
|
|
115
|
|
|
Soren Hansen |
13 years ago
|
|
|