~hudson-openstack/nova/trunk

Viewing all changes in revision 252.

  • Committer: Tarmac
  • Author(s): Ewan Mellor
  • Date: 2010-08-24 00:18:22 UTC
  • mfrom: (228.6.4 xenapi-concurrency-model)
  • Revision ID: hudson@openstack.org-20100824001822-r8a8v8wglnkgnukg
Rework virt.xenapi's concurrency model.  There were many places where we were
inadvertently blocking the reactor thread.  The reworking puts all calls to
XenAPI on background threads, so that they won't block the reactor thread.

Long-lived operations (VM start, reboot, etc) are invoked asynchronously
at the XenAPI level (Async.VM.start, etc).  These return a XenAPI task.  We
relinquish the background thread at this point, so as not to hold threads in
the pool for too long, and use reactor.callLater to poll the task.

This combination of techniques means that we don't block the reactor thread at
all, and at the same time we don't hold lots of threads waiting for
long-running operations.

There is a FIXME in here: get_info does not conform to these new rules.
Changes are required in compute.service before we can make get_info
non-blocking.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: