~indicator-applet-developers/hud/trunk.14.04

Viewing all changes in revision 382.

  • Committer: CI bot
  • Author(s): Charles Kerr
  • Date: 2014-03-25 12:45:22 UTC
  • mfrom: (376.2.6 changes2)
  • Revision ID: ps-jenkins@lists.canonical.com-20140325124522-0gf19r4osgqsq3b7
Simplify the implementation of QtGActionGroup.

This started off with the intent of removing the overhead of g_action_group_list_actions() in QtGActionGroup::Action(), but then I found QtGActionGroup::Action() was only called in the object's constructor and destructor, so it made more sense to remove the function altogether.

Summary of changes:

  * Plugged GVariant leak in QtGActionGroup::TriggerAction()

  * Plugged char* leak in QtGMenuUtils::makeStringListQVariant

  * ActionGroup ctor calls g_action_group_list_actions() once instead of n+1 times

  * ActionGroup dtor calls g_action_group_list_actions() once instead of n times

  * Removed unused public method Size()

  * Removed newly-unused public method Action()

  * Removed newly-unused field m_size Fixes: 1296746

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: